topic Re: ATC not checking code in user exit includes in Application Development and Automation Discussions

ATC not checking code in user exit includes

aubin — Wed, 26 Nov 2014 12:01:26 GMT

Dear Friends,

I'm not sure if you have faced this issue, but I have not found anyone or any post or any document or any OSS note talking about it.

I've recently have realized than when using ATC for checking the custom code of an Z include it was finding cero errors when it was actually full of them.

In fact using code inspector, the errors where found. It was not an issue of using a different variant, this was checked, CI and ATC are using the same,

The issue itself was clear: When the ATC checks a parent object its checks the code of its includes. If you try to check an include directly with ATC, it is ignored with message "No checks are available for the objects types", giving the chance to "add master program" so it will be checked when the master program is checked with all its includes. Last, ATC neither Code Inspector checks custom code.

The end result is that when trying to check the code in a user exit include with ATC it does not find any error.

I can think about encapsulating the code found in a user exits but this is a titanic task.

The main problem is that the jobs for getting in CCLM the quality required massive ATC runs that will not catch the errors in these kind of objects.

Have you face this issue? do you have any recommendation?

I would like your opinion before raising this as customer message, as from my point of this this may require a SAP correction.

Thanks

Aubin

Re: ATC not checking code in user exit includes

former_member183804 — Wed, 26 Nov 2014 18:52:28 GMT

Hello Aubin,

could please provide more details?`

Is the customer exit one of the following:

- enhancement option
- function exit (CMOD et. al)
- form exit (include shipped by application containing forms prefixed with userexit)
- modification

In case of option 1-3 please kindly also add the name of the exit.

How do you trigger the analysis?

Mass run from transaction (ATC / SCI)
Run from Editor on single program
Run on transport (release)

Has the include be changed within the last 7 days?

Kind Regards

Klaus

Re: ATC not checking code in user exit includes

aubin — Thu, 27 Nov 2014 08:57:04 GMT

Hi Klaus, The specific case that I'm talking about was a function exit. Specifically FM EXIT_SAPLCMAT_001 --> Include ZXCIFU01. How did I trigger the analysis? in all the possible ways that I know. 1. The mass run do not detect any issue in the custom code found in the include 2. from editor on FM and include. a) if trying on the FM the ATC directly gives the message "request contains no objects which are checkable by ATC". This is normal since the FM is SAP standard b) if trying the ATC on the include directly, we get the message "No checks available for the object type" so we add the "master program" that is determined as XCIF (the FG of the function exit) and we get the message "The objects passed the chosen checks without any finding”. 3. the same result. I did not know that ATC could only work with recently modified code but just in case I did a small modification obtaining the same results. Additionally I’ve checked with other function exit with exactly the same result. Many thanks Aubin

Re: ATC not checking code in user exit includes

former_member183804 — Thu, 27 Nov 2014 09:13:11 GMT

Hello Aubin,

thanks for your input which will help me to replay this scenario for further analysis and to judge how this limitation can be overcome.

Most likely the behavior is caused by the mapping logic for part objects 2 main objects. Could you please try the following? Analyse your custom package (and its content) that contains the include and the R3TR FUGS XCIF tadir key. Expected behavior is that this time your custom code is checked.

Please also provide your SAP BASIS release and SP level. One can access this information by the top level menu "System\Status" plus pressing the button with the magnify icon.

Thanks

Klaus

Re: ATC not checking code in user exit includes

aubin — Thu, 27 Nov 2014 09:39:57 GMT

Hi Klaus,

I've moved the Z include to a new z package in our sandbox. The one where it was included too many objects to be analyzed. Using ATC on its Z package gives the same result: no ATC findings.

Re the R3TR FUGC XCIF, not sure what do you want me to try. Its package is standard = CIF. I've repeated what I've done already: including in my ATC check the Z include and the XCIF function group with the same results.

Don't you face the same issue with any of your function exits includes?

Our BASIS SP is 740 SP-level 06.

Many thanks for your help on this.

Aubin

Re: ATC not checking code in user exit includes

former_member183804 — Thu, 27 Nov 2014 10:19:33 GMT

Hello Aubin,

to be perfectely honest I have not started with the indeep analysis yet. One reason is that the behaviour regarding exit techniques has got improoved recently so it is important to do the analysis on a SP level close / identical to yours.

If I am not mistaken CMOD function exits yield into 2 TADIR keys:

- 'R3TR' 'FUGX' .... - referring to the definition of the function group - typically provided by SAP - residing in a SAP package

- 'R3TR' 'FUGS' .... - referring to the implementation - typically custom code - residing in a Z-Package

My initial assumpution was that mapping partobjects always return FUGX but shall return FUGS. And also I was assuming the custom package shall contain the 'FUGS' implementation which shall enable checking out of the box.

But it seems these assumptions are not valid. I am not sure wether I would be able to analyse this issue this week. In any case I will update this thread as soon as the analysis has been done.

Best Regards

Klaus

Re: ATC not checking code in user exit includes

aubin — Thu, 27 Nov 2014 11:48:46 GMT

Hi Klaus,

Thanks for the explanation. Now I understand you but is not the other way around? FUGS is the SAP part (SAP Z includes for functions exits) while FUGX is the customer part?

In any case, currently in my system, FUGS it is determined as Master Program (in fact for the example share we do not have created any additional Z include so we do not have FUGX objects).

Additionally, I've found OSS note 2031830- ATC checks for includes return no results. Its title was quite promising but:

a) it is not applicable to my system. in 740 will be only available from SP8 and no advance corrections are possible.

b) it refers to issues in SE80 and transport release. So far we have it not only in these tools but also in SE38, mass run or SCI run.

Many thank for your help on this,

Kind regards,

Aubin

Re: ATC not checking code in user exit includes

Former Member — Mon, 01 Dec 2014 12:40:08 GMT

Hello Aubin,

I have checked the FUGS/FUGS problematic in a SAP_BASIS SP7 system. I get messages for a customer exit FM as well as for the implemented Z... part. As there ar no changes in the underlying coding from SP5 to SP7, that should also work in your system.

So, please provide system access (system name and connection data) as well as a user-ID (with appropriate authorisations) and password so that either Klaus or I can analyse the situation in your system with your above mentioned example.

Either send us the data via e-mail or create an message on component BC-DWB-TOO-ATF and assign me directly as processor.

Regards,

Stefan

Re: ATC not checking code in user exit includes

aubin — Mon, 01 Dec 2014 15:50:10 GMT

Many thanks!

I've open a customer message.

Re: ATC not checking code in user exit includes

Former Member — Thu, 08 Jan 2015 16:35:02 GMT

Dear Aubin,

on 15th of december 2014 we have provided SAP note 2104212 (ATC: Check of customer exit function groups) to solve the problem you have reported. We have provided this information in the customer message that you have created and closed it afterwards.

Did you in the meantime implement the note and does it completely solve the problem? We would appreciate if you can give us feedback here.

Thanks a lot and best regards,

Klaus Ziegler and Stefan Krebs

Re: ATC not checking code in user exit includes

aubin — Thu, 08 Jan 2015 16:55:24 GMT

Dear Klaus and Stefan,

The OSS note provided fixed the issue satisfactory.

I wish you a happy a New Year 2015!

Many thanks for your help an support on this.

Aubin

Re: ATC not checking code in user exit includes

Former Member — Tue, 19 May 2015 07:50:36 GMT

Hi,

I have implemented SAP Note 2104212 successfully.

However finding is in function module, ATC doesn't give any findings.

We have finding for the object as below using extended program check.

PDN

Re: ATC not checking code in user exit includes

aubin — Tue, 19 May 2015 08:16:08 GMT

Hi Kishan,

The reason why you have findings using the extended check not having the same with the ATC check is that your ATC code inspector variant is not including the extended check option.

I would suggest you checking the ATC code inspector variant that you are using.

Best regards

Aubin

Re: ATC not checking code in user exit includes

Former Member — Tue, 19 May 2015 08:39:06 GMT

Hi Aubin,

I already configured extended program check in my code variant but still its not giving any findings.

PDN

Thanks & Regards

Kishan Rana

Re: ATC not checking code in user exit includes

aubin — Tue, 19 May 2015 08:54:58 GMT

Excuse me for the question but do you run the ATC for this specific code inspector variant?

can you show how do you run the ATC?

Re: ATC not checking code in user exit includes

Former Member — Tue, 19 May 2015 09:12:40 GMT

Hi Aubin,

Yes,

I have run the ATC for this specific code inspector variant.

I have done using ABAP TEST COCKPIT WITH -> SELECT CODE VARIANT -> EXECUTE and also,

I have done the same by setting CODE VARIANT as default using admin rights of ATC.

I can't show you the process as per the organization policy.

PDN

Thanks & Regards

Kishan Rana

Re: ATC not checking code in user exit includes

aubin — Tue, 19 May 2015 09:24:02 GMT

Hi Kishan,

When using the "ABAP TEST cockpit with" have you chosen in the tab "Option" your code inspector variant that includes the Extended check?

if you have done it this way and still you do not get the same results than using the SCI directly for the same variant and custom code then you would have an issue that should be review by SAP. I would recommend you opening a message to SAP.

Best regards,

Aubin

Re: ATC not checking code in user exit includes

Former Member — Tue, 19 May 2015 09:36:44 GMT

Hi Aubin,

Can you show how to include Extended check in code inspector variant??

As my object is custom development, SAP will not give any recommendation for the same.

Thanks & Regards

Kishan Rana

Re: ATC not checking code in user exit includes

aubin — Tue, 19 May 2015 09:48:04 GMT

Hi Kishan,

So far, I see from one of you screenshots, you have already included the Extended check in one of your Code Inspector Variants, it is the option you have checked called "Extended program check (SLIN)". unfortunately due to you are hiding the code inspector variant name I do not now in which variant you have configure it and I do not know as you are not sharing it if you are using the same variant when checking using the ATC. But if you are doing it in the right way ATC and code inspector using the same code inspector variant for the same program should give the same results Otherwise you should either look for OSS notes to apply or open a message to SAP as it is clearly a bug in your system.

Regarding SAP giving support they should do it for this case. ATC and code inspector are tools for checking custom code. please remember that they cannot check standard code so checking custom code is the only aim of these tools and if not working properly SAP should support your issue.

I hope I've helped you on this, so far not having more visibility of what you are doing I cannot help you further.

Best regards

Aubin

Re: ATC not checking code in user exit includes

Former Member — Tue, 19 May 2015 10:08:04 GMT

Hi Aubin,

Thanks for your valuable response.

I have re-checked my Function group and I have identified that my functional group also contains some SAP Standard Objects inside.

I have created one function module inside that function group. If u run SCI and SLIN. you will have findings in result but ATC doesn't give any output for the same.

So my question is whether ATC will work on that function group or not?

Thanks & Regards

Kishan Rana