topic Re: need to optimize loop in Application Development and Automation Discussions

need to optimize loop

Former Member — Tue, 26 Aug 2014 19:24:05 GMT

i have to optimize colored line any one heaving idea? Please rply ..

SELECT * FROM zsng2g_pkt_eh

INTO TABLE gt_pkt_eh

WHERE ZSNG2G_ENC_TYPE = gv_par_val_enc

AND ZSNG2G_EPC_CLASS = gv_par_val_epc

AND ZSNG2G_PACKET_LEVEL = '03'

AND ZSNG2G_REQUESTID = gv_id.

**-- selecting all the sn for give packet type list

SELECT eh_guid ZSNG2G_SN_SERIAL_NUMBER ZSNG2G_SN_COUNTER FROM zsng2g_sn_eh

INTO TABLE lt_sn_eh

WHERE ZSNG2G_SN_ENCODING_TYPE = gv_par_val_epc

AND ZSNG2G_SN_EPCCLASS = gv_par_val_enc.

* AND ZSNG2G_SN_COUNTER ge gt_pkt_ehx-ZSNG2G_RANGE_START

* AND ZSNG2G_SN_COUNTER le gt_pkt_ehx-ZSNG2G_RANGE_END.

*--Filling tbl_range

LOOP AT gt_pkt_eh into ls_pkt_eh. "where ZSNG2G_PACKET_TYPE = 'RANGE'.

if ls_pkt_eh-ZSNG2G_PACKET_TYPE = 'RANGE'.

ls_RANGE-RANGE_FROM = ls_pkt_eh-ZSNG2G_RANGE_START.

ls_RANGE-RANGE_TO = ls_pkt_eh-ZSNG2G_RANGE_END.

APPEND ls_range to lt_range.

ELSEif ls_pkt_eh-ZSNG2G_PACKET_TYPE = 'LIST' .

*--Fill tbl_list

LOOP AT lt_sn_eh into ls_sn_eh where ZSNG2G_SN_COUNTER ge ls_pkt_eh-ZSNG2G_RANGE_START and

ZSNG2G_SN_COUNTER le ls_pkt_eh-ZSNG2G_RANGE_END.

ls_list-TABLE_LIST = ls_sn_eh-ZSNG2G_SN_SERIAL_NUMBER.

APPEND ls_list to lt_list.

clear ls_list.

ENDLOOP.

Re: need to optimize loop

Former Member — Tue, 26 Aug 2014 22:21:15 GMT

Hi,

Try to use parallel cursor technique:

Parallel Cursor - 2: without using READ | ABAP Help Blog

Re: need to optimize loop

Former Member — Tue, 26 Aug 2014 22:24:54 GMT

Another tip... try to use this development called Code Lighter. It helps a lot to understand the code when you post in SDN:

Re: need to optimize loop

paul_bakker2 — Wed, 27 Aug 2014 01:47:09 GMT

Hi,

That coloured piece of code just loops at one internal table and fills another.

I can't imagine that it would have any significant effect on performance.

I think you're focusing on the wrong ABAP statements. Have you done a performance trace?

cheers

Paul

Re: need to optimize loop

Former Member — Wed, 27 Aug 2014 02:14:07 GMT

in second loop it has condition.in parallel cursor method how to implement this becaz read is not possible with le and ge operator

Re: need to optimize loop

Former Member — Wed, 27 Aug 2014 02:14:25 GMT

in second loop it has condition.in parallel cursor method how to implement this becaz read is not possible with le and ge operator

Re: need to optimize loop

paul_bakker2 — Wed, 27 Aug 2014 11:21:06 GMT

Like I said, that's not where your performance problem is.

cheers

Paul

Re: need to optimize loop

VenkatRamesh_V — Wed, 27 Aug 2014 11:32:47 GMT

Hi Manisha,

Try this.

Instead of work area declare field symbols.

Field symbols: <fs> like line of gt_pkt_eh.

LOOP AT gt_pkt_eh ASSIGNING <fs>.

CHECK ( <fs>-PACKET_TYPE = 'RANGE' OR

<fs>-PACKET_TYPE = 'LIST' ).

ENDLOOP.

Regards,

Venkat.

Re: need to optimize loop

Former Member — Wed, 27 Aug 2014 11:55:33 GMT

As per

SAP Documentation

CASE statements are clearer and a little faster than

IF-constructions.

Regards,

Avirat

Re: need to optimize loop

SuhaSaha — Wed, 27 Aug 2014 12:03:46 GMT


Avirat Patel wrote:

As per SAP Documentation
CASE statements are clearer and a little faster than
IF-constructions.

Which SAP documentation?

"Clearer", agreed. "Faster", don't agree unless someone posts detailed runtime analysis.

Re: need to optimize loop

Former Member — Wed, 27 Aug 2014 12:20:48 GMT

Dear Suhas I got this details from following screen.

Re: need to optimize loop

SuhaSaha — Wed, 27 Aug 2014 12:23:18 GMT

What does the "Measure runtime" tell you? Do you see any appreciable difference in runtimes?

Re: need to optimize loop

Former Member — Wed, 27 Aug 2014 12:32:30 GMT

May be it works well where huge amount of data is available. and if It does not then why SAP has mentioned this note [Raising eyebrow].

if you know [you are a gem and i'm following you/your post always] kindly tell me .

Re: need to optimize loop

ThomasZloch — Wed, 27 Aug 2014 12:33:41 GMT

That's the age-old SE80 performance examples...my results:

IF: 0 microseconds

CASE: 0 microseconds

It seems that CPU-Power has increased somewhat since the tests were designed (15 years ago?)

Thomas

Re: need to optimize loop

Former Member — Wed, 27 Aug 2014 12:36:43 GMT

Hi Manisha,

I just modified the colored code, just try this in your system and see any performance

1. Declare one more field flag type c in lt_sn_eh

2. Declare internal table lt_sn_eh as i mentioned

data lt_sn_eh type TABLE OF xxxxx with NON-UNIQUE SORTED KEY sn_counter COMPONENTS zsng2g_sn_counter.

*--Filling tbl_range

ls_sn_eh-flag = abap_true. " to make required entries

LOOP AT gt_pkt_eh INTO ls_pkt_eh. "where ZSNG2G_PACKET_TYPE = 'RANGE'.

IF ls_pkt_eh-zsng2g_packet_type = 'RANGE'.

ls_range-range_from = ls_pkt_eh-zsng2g_range_start.

ls_range-range_to = ls_pkt_eh-zsng2g_range_end.

APPEND ls_range TO lt_range.

ELSEIF ls_pkt_eh-zsng2g_packet_type = 'LIST' .

*--Fill tbl_list

MODIFY lt_sn_eh FROM ls_sn_eh USING KEY sn_counter TRANSPORTING flag WHERE zsng2g_sn_counter GE ls_pkt_eh-zsng2g_range_start AND

zsng2g_sn_counter LE ls_pkt_eh-zsng2g_range_end.

ENDIF.

ENDLOOP.

LOOP AT lt_sn_eh ASSIGNING <fs_sn_eh> USING KEY sn_counter.

if <fs_sn_eh>-flag = abap_true.

ls_list-table_list = ls_sn_eh-zsng2g_sn_serial_number.

APPEND ls_list TO lt_list.

CLEAR ls_list.

endif.

ENDLOOP.

Re: need to optimize loop

Former Member — Wed, 27 Aug 2014 12:39:26 GMT

It means that SAP has not upgrade its old age documentation?

Re: need to optimize loop

SuhaSaha — Wed, 27 Aug 2014 12:41:19 GMT


That's the age-old SE80 performance examples...my results:

They are still available on the latest runtime analysis tool - SAT

Re: need to optimize loop

SuhaSaha — Wed, 27 Aug 2014 12:43:16 GMT


Avirat Patel wrote:

It means that SAP has not upgrade its old age documentation?

Yeah! SAP & documentation, that's been on every ABAPer wishlist ad infinitum.

Re: need to optimize loop

Former Member — Wed, 27 Aug 2014 12:48:36 GMT

In that case we have to strongly follow gurus (Suhas & Thomas Z)

and getting valuable tips & tricks

Re: need to optimize loop

ThomasZloch — Wed, 27 Aug 2014 12:50:16 GMT

Correct, there is a few examples for this. Doesn't make it easier to combat some of the "urban legends"...

In general, I would always look for significant differences when comparing runtimes and adjusting code (especially when code becomes more complex this way). Definition of "significant" might vary based on circumstances, but a few percent is not worth any effort in most cases.

The biggest performance hazards in my experience is still access to large data (DB or internal table) without index support, even more so when done in loops, and excessive memory usage (paging to disk).

Thomas