topic Re: SELECT question. in Application Development and Automation Discussions

SELECT question.

Former Member — Mon, 12 Jun 2006 23:15:35 GMT

Hi people,

I don't have more choice to take out the selects from this loop. Now the question is if I insert the data of a select in a internal table when the loop is running like this:


LOOP AT t_regup INTO wa_regup .

    SELECT  usnam cpudt belnr stblg
     FROM bkpf INTO CORRESPONDING FIELDS OF table t_bkpf1
        WHERE belnr = wa_regup-belnr
        AND   bukrs = wa_regup-bukrs.

     SELECT znme1 lifnr laufd laufi zbukr hbkid   
                 waers zaldt
                 hktid vblnr chect zland rzawe uzawe voidr
      FROM payr INTO CORRESPONDING FIELDS OF table t_payr1
           WHERE  hbkid = wa_regup-hbkid
             AND  hktid = wa_regup-hktid
             AND  zbukr = wa_regup-zbukr
             AND  voidr = ''.

the lines are inserted line by line, so I don't need to use an append?, because I try to not use the 'ENDSELECT.' statement.

Thanks for the help.

Re: SELECT question.

suresh_datti — Mon, 12 Jun 2006 23:21:11 GMT

Replace INTO with APPENDING in both the SELECT Statements. Otherwise, the itabs might be overwritten with each loop pass.

Regards,

Suresh Datti

Re: SELECT question.

abdul_hakim — Mon, 12 Jun 2006 23:23:40 GMT

hi structure ur SELECT as follows for better performance..

IF NOT t_regup IS INITIAL.

SELECT usnam cpudt belnr stblg FROM bkpf INTO CORRESPONDING FIELDS OF table t_bkpf1

FOR ALL ENTRIES IN t_regup

WHERE belnr = t_regup -belnr AND

bukrs = t_regup -bukrs.

ENDIF.

IF NOT t_regup IS INITIAL.

SELECT znme1 lifnr laufd laufi zbukr hbkid waers zaldt hktid vblnr chect zland rzawe uzawe voidr FROM payr INTO CORRESPONDING FIELDS OF table t_payr1

FOR ALL ENTRIES IN t_regup

WHERE hbkid = t_regup -hbkid AND

hktid = t_regup -hktid AND

zbukr = t_regup -zbukr AND voidr = ''.

ENDIF.

Cheers,

Abdul Hakim

Re: SELECT question.

Former Member — Mon, 12 Jun 2006 23:24:06 GMT

Carlos,

There is no need to use an APPEND in your case. As you are populating an internal table in your select.

SELECT....ENDSELECT is like a loop and you have to use APPEND to add record to an internal table.

Hope this is what you have asked.

Thanks,

Re: SELECT question.

Former Member — Mon, 12 Jun 2006 23:24:51 GMT

So, if I replace the into by the append I don't need to use ENDSELECT statement right?

Re: SELECT question.

suresh_datti — Mon, 12 Jun 2006 23:25:31 GMT

YES.

Suresh Datti

Re: SELECT question.

Former Member — Mon, 12 Jun 2006 23:25:37 GMT

Yes...if you replace into with appending there is no need to use endselect.

Thanks,

Re: SELECT question.

abdul_hakim — Mon, 12 Jun 2006 23:27:54 GMT

you could use my above logic to fetch the data from the tables in one shot and keep it in two internal tables and later you can loop thru the two tables based on the key fields and append it to the final table.this will improve ur performance a lot.if you place SELECT query in between LOOP and ENDLOOP it will affect your performance.

Plz check the performance tuning of ABAP programs under the knowledge pool portal http://help.sap.com

Cheers,

Abdul Hakim

Re: SELECT question.

Former Member — Tue, 13 Jun 2006 03:17:39 GMT

Before you make any changes, we should know your requirements. The code snippet you have shwon us will overwrite your internal table for each loop pass. That may be what you want if you are processing each line of t_regup individually; however, if you want to get all of your data up front and process it outside of the loop, then you need to do the FOR ALL ENTRIES as suggested by Abdul.

Rob

Message was edited by: Rob Burbank