topic Code Inspector - Approval step for pseudo comments in Application Development and Automation Discussions

Code Inspector - Approval step for pseudo comments

Former Member — Mon, 28 Oct 2013 14:06:37 GMT

Within SAP code inspector certain messages can be suppressed by adding pseudo comments to the relevant line ("#EC WHATEVER). In the SAP help SAP Library - Test and Analysis Tools in ABAP it explains a mechanism for requesting approval to suppress SCI errors.

"You must designate one or more users with full Code Inspector authorizations to review and approve exceptions. You must tell your developers which users are responsible for their exceptions.

Developers apply for exceptions from the results of code inspections. To complete an exception request, a developer must enter the name of the user who should review the request."

The problem is that while I can find (on the initial screen of SCI) a list of Exception requests I have raised, or that have been raised for my approval, I can't find a way to actually raise them. I have an SCI result, including an error that can be suppressed with an exception but can find no way from this report to raise an exception request.

Any ideas?

Thanks,

Nick

Re: Code Inspector - Approval step for pseudo comments

RaymondGiuseppi — Mon, 28 Oct 2013 14:13:51 GMT

You can trigger a SCI check at transport request release (1), this should trigger your workflow.

Else you could create a small report (2) that execute SCI on every suitable object of every open transport request periodically.

Regards,

Raymond

(1) SE03 Transport tools -> Global Customizing (Transport Organizer) -> Object checks when request released

(2) e.g. calling SCI_INSPECT_LIST on result of TR_GET_OBJECTS_OF_REQ_AN_TASKS (list of object)s and TR_TRANSFORM_TADIR_TO_EU_TYPE (convert object directory types to editor types)

Re: Code Inspector - Approval step for pseudo comments

Former Member — Mon, 28 Oct 2013 14:35:09 GMT

Hi Raymond,

Thanks for the reply.

As I interpret it, the functionality I've quoted from the SAP help does not relate to workflow (the fact you need to know that name of the approver suggests fairly basic functionality) or specifically to the SCI check at transport release.

On the initial screen of transaction SCI the menu option Goto -> Exceptions -> Approve lists the SCI exception requests that have been assigned to me, and Goto -> Exceptions -> Requested lists those I have raised. And while the SAP help explains "Developers apply for exceptions from the results of code inspections" there nothing explaining how this is done and nothing I can find in the SCI results list to do this.

Is this half-delivered functionality, or am I missing something?

Regards,

Nick

Re: Code Inspector - Approval step for pseudo comments

SuhaSaha — Mon, 28 Oct 2013 14:57:22 GMT

Hello Nick,

I was not aware of this functionality of SCI; seems to me SCI is more powerful than most of us think

Anyway -

In practice, this limitation means that developers should use the Code Inspector in the QA system. Only there will check messages be hidden by exceptions.

This is quite confusing

BR,

Suhas

Re: Code Inspector - Approval step for pseudo comments

Former Member — Mon, 28 Oct 2013 15:48:03 GMT

Bit more detail.

From debugging the SCI menu option Goto -> Exceptions -> Approve, this functionality seems to be based around tables SCIEXCEPTN_APPL and SCIEXCEPTN, and the class CL_CI_EXCEPTION.

However the methods in this class that seem to relate to the creation of the exception don't seem to be called from the SCI (essentially program SAPLS_CODE_INSPECTOR).

Still looking a lot like half delivered functionality.

Nick

Re: Code Inspector - Approval step for pseudo comments

RaymondGiuseppi — Mon, 28 Oct 2013 15:49:01 GMT

Also I tried some x-ref search, and find many not referenced object like method SAVE_AS_APPROVER of class CL_CI_EXCEPTION and the like. (And looking for a keyword like EXCEPTION in code is not easy...) I don't find any option in PAI/handled event/context menu in display SCI results code... (checked in release 731)

Regards,

Raymond

Re: Code Inspector - Approval step for pseudo comments

Former Member — Mon, 28 Oct 2013 16:10:22 GMT

Using the table name as search criteria I've found this;

So, the approval functionality is only available for checks with an Exception 'Table Entry' rather than a pseudo comment. The delivered ones with this set seem to be ABAP internal statements, most have nothing or a pseudo comment.

To my own slight embarassment, it does actually say this in the first line of the help I linked in my original question.

"To see which messages may be masked with exceptions, choose Goto -> Management of -> Message Priorities. Table entry in the Exception column means that an exception can be

requested."

Thanks everyone for the input.

Regards,

Nick