topic Re: at selection screen in Application Development and Automation Discussions

at selection screen

Former Member — Tue, 11 Jun 2013 08:48:48 GMT

Hi every one,

AT SELECTION-SCREEN on s_lifnr .

if not s_lifnr is INITIAL.

SELECT SINGLE lifnr

INTO v_lifnr

FROM LFA1

WHERE LIFNR IN S_LIFNR.

IF SY-SUBRC <> 0.

MESSAGE 'INVALID ACCOUNT NUMBER' TYPE 'E'.

ENDIF.

\mine is not validating......wrong ans also executing

Re: at selection screen

Former Member — Tue, 11 Jun 2013 09:27:56 GMT

Try putting,

AT SELECTION-SCREEN on s_lifnr .

perform validate_vendor.

form validate_vendor.

if not s_lifnr is INITIAL.

CALL FUNCTION 'CONVERSION_EXIT_ALPHA_INPUT'

EXPORTING

input = s_lifnr

IMPORTING

OUTPUT =s_lifnr

SELECT SINGLE lifnr

INTO v_lifnr

FROM LFA1

WHERE LIFNR IN S_LIFNR.

IF SY-SUBRC <> 0.

MESSAGE 'INVALID ACCOUNT NUMBER' TYPE 'E'.

ENDIF.

endform.

BR,

Ankit.

Re: at selection screen

Former Member — Tue, 11 Jun 2013 09:41:25 GMT

Hi Meenakshi.

1. At Selection screen on we use for single fields in general like for S_LIFNR-LOW / S_LIFNR-HIGH.

2. If you need to validate the entire select opt try like this.

SELECTION-SCREEN BEGIN OF BLOCK BL0.

SELECT-OPTIONS SEL1 FOR SY-TVAR1.

SELECTION-SCREEN END OF BLOCK BL0.

At selection-screen on block b0.

IF s-lifnr[] is not initial.

SELECT SINGLE lifnr

INTO v_lifnr

FROM LFA1

WHERE LIFNR IN S_LIFNR.

IF SY-SUBRC <> 0.

MESSAGE 'INVALID ACCOUNT NUMBER' TYPE 'E'.

ENDIF.

Endif.

OR if you want single fields

The write.

At selection-screen on S_LIFNR-HIGH.

IF s_lifnr-high is not initial.

SELECT SINGLE lifnr

INTO v_lifnr

FROM LFA1

WHERE LIFNR eq S_LIFNR-high.

IF SY-SUBRC <> 0.

MESSAGE 'INVALID ACCOUNT NUMBER' TYPE 'E'.

ENDIF.

Endif.

Similarly for low

Hope it helps

Re: at selection screen

Former Member — Tue, 11 Jun 2013 09:56:28 GMT

Hi Meenakshi,

I executed the piece of code that you have written and it worked fine for me. The reason that select query fails maybe because the variable v_lifnr is of different type compared to the field lifnr in lfa1 table. Do check the variable declaration and see if data type is same as the table field value you are fetching.

Hope this helps,

~Athreya

Re: at selection screen

jayanthi_jayaraman — Tue, 11 Jun 2013 09:57:41 GMT

Hi,

Do you want to provide error message if none of the LIFNR is available? If so, the below should be fine. Because it checks the range what you had provided. If you want to check each and every LIFNR in the range, you need to have loop between s_lifnr-low and s_lifnr-high.

AT SELECTION-SCREEN on s_lifnr .

if s_lifnr[] is not INITIAL.

SELECT SINGLE lifnr

INTO v_lifnr

FROM LFA1

WHERE LIFNR IN S_LIFNR.

IF SY-SUBRC <> 0.

MESSAGE 'INVALID ACCOUNT NUMBER' TYPE 'E'.

ENDIF.

Re: at selection screen

RaymondGiuseppi — Tue, 11 Jun 2013 09:58:52 GMT

Check documentation (F1) AT SELECTION-SCREEN ON selcrit will only be triggered for a line of selection, to get whole selection internal table use ON END OF selcritif user use the dialog box for select-options, so you may be require to put your check in a simple AT SELECTION-SCREEN..

Sample to check :

TABLES: lfa1.
 
 SELECT-OPTIONS s_lifnr FOR lfa1-lifnr.
 
 AT SELECTION-SCREEN ON END OF s_lifnr .
   IF NOT s_lifnr[] IS INITIAL.
     SELECT COUNT(*)
     FROM lfa1
     WHERE lifnr IN s_lifnr.
     IF sy-subrc <> 0.
       MESSAGE 'AT END OF selcrit' TYPE 'S'.
     ENDIF.
   ENDIF.
 
 AT SELECTION-SCREEN ON s_lifnr .
   IF NOT s_lifnr IS INITIAL.
     SELECT COUNT(*)
     FROM lfa1
     WHERE lifnr IN s_lifnr.
     IF sy-subrc <> 0.
       MESSAGE 'AT selcrit' TYPE 'S'.
     ENDIF.
   ENDIF.
 
 AT SELECTION-SCREEN.
   IF NOT s_lifnr IS INITIAL.
     SELECT COUNT(*)
     FROM lfa1
     WHERE lifnr IN s_lifnr.
     IF sy-subrc <> 0.
       MESSAGE 'AT nothing' TYPE 'S'.
     ENDIF.
   ENDIF.

Regards,

Raymond

Re: at selection screen

Former Member — Tue, 11 Jun 2013 10:03:38 GMT

Hi,

Following code is working fine for me throws error,

data : lv_lifnr type lifnr.

select-options : s_lifnr for lv_lifnr.

at selection-screen on s_lifnr .

if not s_lifnr is initial.

select single lifnr

into lv_lifnr

from lfa1

where lifnr in s_lifnr.

if sy-subrc <> 0.

message 'INVALID ACCOUNT NUMBER' type 'E'.

endif.

Regards,

Ravi Shankar L

Re: at selection screen

Former Member — Tue, 11 Jun 2013 10:23:01 GMT

Hi Meenakshi,

The code which you had done to validate the vendor is perfect. Please check it properly.

Thanks & Regards.

Pavan.N

Re: at selection screen

Former Member — Tue, 11 Jun 2013 10:36:24 GMT

Your code seems to be fine.

Another option is, Instead of selection screen on s_lifnr.

Just give

At Selection-screen.

AT SELECTION-SCREEN.
   if not s_lifnr is INITIAL.
     select single lifnr into v_lifnr from lfa1 where lifnr in s_lifnr.
     if sy-subrc ne 0.
       MESSAGE 'Invalid Account No' type 'E'.
     endif.
   endif.

The event block sequence should be correct.

Selection Screen Declarations

at selection screen output

at selection screen

at selection screen on <field>

start of selection.

http://help.sap.com/saphelp_46c/helpdata/en/fc/eb2d67358411d1829f0000e829fbfe/content.htm

Re: at selection screen

Former Member — Tue, 11 Jun 2013 11:05:34 GMT

Hi Meena,

As per my knowledge,

You are define select option in your selection screen it is nothing but an one internal table then how can you use single select statement. And also if user does not enter any value in the select option it will get the all vendor details.

If suppose your vendor selection is parameter then it will work fine.

For your understanding go through the following code,

TYPES: BEGIN OF ll,
        lv_lifnr type lifnr,
        END OF ll.

DATA: lv_lifnr type lifnr,

       lt_lifnr TYPE TABLE OF ll.

SELECT-OPTIONS s_lifnr for lv_lifnr.

AT SELECTION-SCREEN on s_lifnr .

perform validate_vendor.

form validate_vendor.
if not s_lifnr is INITIAL.
"IF SUPPOSE USER SELECT THE VENDOR NUMBER FROM SH IT IS NOT REQUIRED
*CALL FUNCTION 'CONVERSION_EXIT_ALPHA_INPUT'
*
*   EXPORTING
*
*     input         = s_lifnr
*
*IMPORTING
*
*   OUTPUT        = s_lifnr

SELECT lifnr INTO TABLE lt_lifnr FROM LFA1 WHERE LIFNR IN S_LIFNR.

IF SY-SUBRC <> 0.
MESSAGE 'INVALID ACCOUNT NUMBER' TYPE 'E'.
ENDIF.
ELSE.
MESSAGE 'PLEASE ENTER VENDOR NUMBER' TYPE 'E'.
ENDIF.
endform.

Warm Regards,

John.

Re: at selection screen

Former Member — Tue, 11 Jun 2013 11:47:54 GMT

Hi Meenakshi,

I suppose I got your point.... and there is some confusion...

A Select Option is a RANGE so if I put "A" To "Z".

Though the Table contains only B,C, D & E it will return all 4 as they fall in range.

So your select will not validate B , C , D or E individually.

If you want that you have to use the No interval that will force the user to enter single values and you can validate each of them

Re: at selection screen

Former Member — Tue, 11 Jun 2013 11:48:12 GMT

Hi Meenakshi,

I suppose I got your point.... and there is some confusion...

A Select Option is a RANGE so if I put "A" To "Z".

Though the Table contains only B,C, D & E it will return all 4 as they fall in range.

So your select will not validate B , C , D or E individually.

If you want that you have to use the No interval that will force the user to enter single values and you can validate each of them

Re: at selection screen

Former Member — Wed, 12 Jun 2013 05:41:14 GMT

Hi Pavan,

The code is validating ok but wat means wen i give range of values say 45 to 50 where 47 is not available instead to it s taking in to account. I need help in this area.

Regards,

Meenakshi.

Re: at selection screen

Former Member — Wed, 12 Jun 2013 06:17:24 GMT

HI ANKIT,

it is validating the 1st vale in the selection screen not the other range of values.

Re: at selection screen

Former Member — Wed, 12 Jun 2013 06:45:17 GMT

Hi Meenakshi,

For select options, it checks for the range not for individual account numbers.

Select option is the table with header line with the following structure .

So if you give a range the option would be BT.

if you give a single value, or multiple values (using this button ), the option would be EQ. Each account number will be appended to the table.

For Between option, you need to manually check for all the values.

data : msg type string, c_lifnr(10) type c.

at selection-screen on s_lifnr.

if not s_lifnr is INITIAL.

case s_lifnr-option.

when 'BT'.

lv_lifnr1 = s_lifnr-low.

do.

if lv_lifnr1 GT s_lifnr-high.

exit.

endif.

select single lifnr into v_lifnr from lfa1 where lifnr = lv_lifnr1.
if sy-subrc ne 0.

c_lifnr = lv_lifnr1.

                  concatenate 'Invalid Account No' c_ lifnr into msg.
                  MESSAGE msg type 'E'.
              endif.

lv_lifnr1 = lv_lifnr1 + 1.

enddo.

when 'EQ'.

loop at s_lifnr.

select single lifnr into v_lifnr from lfa1 where lifnr = s_lifnr-low.
if sy-subrc ne 0.

c_lifnr = s_lifnr-low.

                        concatenate 'Invalid Account No' c_lifnr into msg.
                       MESSAGE msg type 'E'.
                     endif.

endloop.

endcase.

Or another option is just allow one account number at a time.

parameters : p_lifnr like lfa1-lifnr.

at selection-screen on p_lifnr.

select single lifnr into v_lifnr from lfa1 where lifnr = p_lifnr.
if sy-subrc ne 0.

MESSAGE 'Invalid Account No' type 'E'.
endif.

Re: at selection screen

jayanthi_jayaraman — Wed, 12 Jun 2013 06:53:55 GMT

Hi,

You can either restrict the intervals by no intervals or you can check as below which will help you to check if atleast one provided in the interval is valid. If you want to check everything in the interval, then you need to take everything in another internal table by looping s_lifnr from low and high.

select-options : s_lifnr for lv_lifnr.
   at selection-screen on s_lifnr .
      if s_lifnr[] is not initial.
      select single lifnr into lv_lifnr
        from lfa1 where lifnr in s_lifnr.
        if sy-subrc ne 0.
          message ...
        endif.
endif.

Re: at selection screen

Former Member — Wed, 12 Jun 2013 07:09:01 GMT

hi Mohanmed,

But in input the range of values to be entered mand......

Re: at selection screen

Former Member — Wed, 12 Jun 2013 07:12:49 GMT

how is that possible? by using the condition loop

Re: at selection screen

Former Member — Wed, 12 Jun 2013 07:53:35 GMT

Hi Meenakshi,

check the coding given by Susmitha. It is the correct way to validate present inside the range.

Let me know if any clarifications needed.

Thanks

Pavan.N

Re: at selection screen

Former Member — Wed, 12 Jun 2013 07:53:35 GMT

Hi Meenakshi,

check the coding given by Susmitha. It is the correct way to validate present inside the range.

Let me know if any clarifications needed.

Thanks

Pavan.N