topic Re: Problem with Binary search. in Application Development and Automation Discussions

Problem with Binary search.

Former Member — Fri, 10 May 2013 11:50:45 GMT

I am looping and internal table, and reading the same internal table inside the loop when certain if conditions are satisfied.
The issue is the Read statement is not successful with the addition Binary search, even though is satifies all the if conditions.
It returns a sy-subrc value as 8.

When i remove the Binary search addition, the Read statement is successful with sy-subrc = 0. I have sorted the internal table before the loop.

Can anyone explain why its happeing so?

Re: Problem with Binary search.

matt — Fri, 10 May 2013 15:33:19 GMT

Define your tables as SORTED and a) you'll be using the more recent technology, introduced just 13 years ago... and b) you won't have BINARY SEARCH to add, so your problem will go away.

Re: Problem with Binary search.

ronaldo_aparecido — Fri, 10 May 2013 15:50:32 GMT

The problem is probably why u are not using the SORT command before giving the command read.

Note: The sort command should be done for the condition of the field used in the read

Example:

Puts the sort before

it_mara sort by ascending MATNR.

Read table with key it_mara into wa_mara lsmara-MATNR MATNR = binary search.

Re: Problem with Binary search.

kamesh_g — Fri, 10 May 2013 16:00:05 GMT

Option 1.

define your internal table as sorted table

ex : lt_table type sorted table of <structure/table ref> with key -latest

option 2 :

Make sure you sorted your internal table with all the fields which you are using in read statement other wise read will fail .

Re: Problem with Binary search.

Former Member — Fri, 10 May 2013 17:29:36 GMT

You have to sort your internal table by the fields that you're comparing in READ statement. Place the SORT statement just before the READ TABLE.

Re: Problem with Binary search.

RaymondGiuseppi — Mon, 13 May 2013 11:32:16 GMT

Just read the documentation of the BINARY SEARCH option, to understand.

Regards,

Raymond

Re: Problem with Binary search.

Former Member — Mon, 13 May 2013 12:47:30 GMT

Thanks experts, I got the solution.

The issue with my code was that, i had sorted the internal table with the specified keys in descending.

But Binary Search in the read statement works, only if the internal table is sorted with the same keys in the Read statement in Ascending order.

Thanks Raymond for your link.

Re: Problem with Binary search.

kamesh_g — Tue, 14 May 2013 15:21:31 GMT

Text removed by moderator

(And he couldn't give points as the post was unmarked as a question)

Message was edited by: Matthew Billingham

Re: Problem with Binary search.

Former Member — Wed, 15 May 2013 06:59:42 GMT

Hi Deepti,

Please SORT your table with KEY before you use it in READ with Binary Search.

This is the prerequisite with BINARY SEARCH, that your table must be SORTED before READ.

For example:

SORT itab by fld_xyz.

Read table itab with KEY fld_xyz = 'X'.

Hope this'll solve your issue.

Re: Problem with Binary search.

venusrini36 — Thu, 26 Oct 2023 07:15:25 GMT

Yes, you are right. It is better to use SORT command exactly one line before the READ <ITAB> INTO <WA> WITH KEY <CONDITION> BINARY SEARCH

Reason: If the READ statement is used inside the loop, there may be chances that <ITAB> values gets added or removed and the sorting order of <ITAB> gets changed. So every time the READ statement is accessed inside the loop, the SORT statement should be accessed every time to get the successful results(SY-SUBRC = 0). Otherwise, We will get error while accessing READ statement with BINARY SEARCH(SY-SUBRC = 😎