topic Re: Transform from basic to object in Application Development and Automation Discussions

Transform from basic to object

Former Member — Thu, 18 Apr 2013 09:17:59 GMT

Hi Experts,

Is there anyway to turn this kind of basic abap code into abap object one?

READTABLE Internal INTO area WITH KEY
ytest = source_fields_rule-gl_account
BINARYSEARCH.

IF area-flag = 'N'.
CLEAR RESULT.
ENDIF.

IF area-flag = 'Y'.

           IF area-tpr ISINITIAL.
               RESULT = SOURCE_FIELDS_RULE-value.
             ELSE.
               RESULT = area-tpr.

ENDIF.
ENDIF.

Thanks.

Amine

Re: Transform from basic to object

UweFetzer_se38 — Thu, 18 Apr 2013 11:30:57 GMT

Hi Amine,

I don't understand your question. Is there a syntax check error in ABAP OO context?

Re: Transform from basic to object

Former Member — Thu, 18 Apr 2013 12:47:02 GMT

Hi Uwe,

No there is no errors, but i would like to change it in an objects style not the basic abap....

I don't know if it's more clear

Amine

Re: Transform from basic to object

Clemenss — Thu, 18 Apr 2013 13:14:06 GMT

Hi amine,

for oo programming please refer to google. You will find tons of learning material. What is you oo expertise/training level?

In your case, you can use a functional method importing source_fields_rule returning RESULT.

But your code is buggy as it is:

READTABLE ... BINARYSEARCH and no check for SY-SUBRC will cause unpredictable errors if no matching record is found.

Regards

Clemens

Re: Transform from basic to object

Former Member — Thu, 18 Apr 2013 14:22:13 GMT

Thanks for the advice Clemens.

Amine

Re: Transform from basic to object

UweFetzer_se38 — Fri, 19 Apr 2013 08:54:05 GMT

There is no "object style" ABAP. This code block will look exactly the same in ABAO OO (needs some "optimization" though, see Clemens' comment, but this is another story).

Re: Transform from basic to object

Former Member — Fri, 19 Apr 2013 09:15:02 GMT

I taked account of Clemens remark.

Do you see any other optimization that i can add to my code?

Thanks.

Amine