topic Re: Performance issue with IF statement in Application Development and Automation Discussions

Performance issue with IF statement

Former Member — Thu, 14 Mar 2013 05:57:22 GMT

Hi All,

I'm using below if condition , is their any way to avoid multiple IF conditions ?

Constants : C_N(1) type C value 'N',
            C_S(1) type C value 'S',
            C_E(1) type C value 'E',
            C_A(1) type C value 'A',
            C_C(1) type C value 'C',
            C_R(1) type C value 'R',
            C_M(1) type C value 'M'.

if it_debit-status = C_N or
   it_debit-status = C_S or
it_debit-status = C_E or
it_debit-status = C_A or
it_debit-status = C_C or
it_debit-status = C_R or
it_debit-status = C_M.

Re: Performance issue with IF statement

JJosh — Thu, 14 Mar 2013 06:06:25 GMT

Hi Smitha,

Try the below codes..

1. Sort it_debit by status.

2. Try using Case.... End Case.

3. Delete it_debit where Status NOT IN (XXXX).

Re: Performance issue with IF statement

Former Member — Thu, 14 Mar 2013 06:12:08 GMT

Hi Smitha,

You can code like this:

LOOP AT IT_DEBIT INTO WA_DEBIT.

CASE STATUS.

WHEN C_N.

WHEN C_S.

WHEN C_E.

WHEN C_A

WHEN C_C.

WHEN C_R.

WHEN C_M.

WHEN OTHERS.

ENDCASE.

CLEAR WA_DEBIT.

ENDLOOP.

You do not have to add any logic for WHEN OTHERS. But it is a good practise to include that as well. Hope this helps!

Re: Performance issue with IF statement

Former Member — Thu, 14 Mar 2013 06:17:08 GMT

Hi Smitha,

If you are using if conditions in your program it will kill the performance.because it will check each and every condition ..but if you use case and endcase only it will trigger if the condition satisfies.

Thanks

Pavan.

Re: Performance issue with IF statement

Former Member — Thu, 14 Mar 2013 06:26:22 GMT

Can we use Check ?

Re: Performance issue with IF statement

Former Member — Thu, 14 Mar 2013 06:29:49 GMT

Case...Endcase is always better than CHECK

Re: Performance issue with IF statement

Kartik2 — Thu, 14 Mar 2013 06:39:59 GMT

Hi,

Without using IF it can be acieved by using ranges or select options. Please use the following code:

   data char type char01.

select-options s_number for char no-display.

s_number-sign   = 'I'.
s_number-option = 'EQ'.
s_number-low    = 'A'.
append s_number to s_number.

s_number-sign   = 'I'.
s_number-option = 'EQ'.
s_number-low    = 'E'.
append s_number to s_number.

s_number-sign   = 'I'.
s_number-option = 'EQ'.
s_number-low    = 'C'.
append s_number to s_number.

char = 'D'.

if char in s_number.

endif.

You can change the names of variables accordingly. Thank you.

Regards,

Kartik

Re: Performance issue with IF statement

Former Member — Thu, 14 Mar 2013 06:52:07 GMT

Hi,

Make use of ranges.

Thanks,

Tooshar Bendale

Re: Performance issue with IF statement

kakshat — Thu, 14 Mar 2013 06:57:46 GMT

Hi Smitha,

Yes, you can use CHECK but even with that you will have to write all the conditions. And, that's the case with CASE too!

You can avoid multiple conditions in case there are very few (only a couple for example) values for which you don't want the logic to be executed. So, you have several values (N, S, E, A, C, R, M) for which you want to execute your logic. If the values for which you don't want to execute this logic are very few (let's say only one - Z), you can do with a single IF condition using the <> operator i.e. IF STATUS <> 'Z'.

Also, CHECK statement is generally used to exit a block of code if certain conditions are not met. So, it has a semantic significance attached to it. For cases where you want to perform different things based on different conditions, IF or CASE would be better.

Re: Performance issue with IF statement

Former Member — Thu, 14 Mar 2013 07:29:23 GMT

Hi,

The best option is to use CASE- ENDCASE statement, in this case.

Nitin

Re: Performance issue with IF statement

RaymondGiuseppi — Thu, 14 Mar 2013 08:08:38 GMT

Did SAT or SE30 raise actually any performance problem on this statement

Else for maintenanbility (but not much for perfiormance) you could write

CASE  it_debit-status.
  WHEN c_n OR c_s OR c_e OR c_a OR c_c OR c_r OR c_m.
    " ...
  WHEN OTHERS.
    " ...
ENDCASE.

Regards,

Raymond