topic Re: loop in loop performance in Application Development and Automation Discussions

loop in loop performance

Former Member — Thu, 20 Dec 2012 14:59:14 GMT

I have to make loop inside a loop ı am looking fastest way to do

my internal tables likes these (not excatly but similiar)

data begin of itabex

matnr like mara-matnr

lgort like mspr-lgort

charg like mspr-charg

data end of itabex

data begin of itabin

matnr like mara-matnr

lgort like mspr-lgort

charg like mspr-charg

data end of itabin

loop at itabex

loop at itabin where matnr eq itabex-matnr

and lgort eq itabex-lgort

endloop

endloop.

sort itabin by matnr lgort.

loop at itabex.

read table itabin with key matnr = itabex-matnr

lgort = itabex-lgort binary search.

if sy-subrc eq 0.

lv_tabix = sy-tabix.

loop at itabin from lv_tabix.

if itabin-matnr ne itabex-matnr or

itabin-lgort ne itabex-lgort.

exit.

endif.

endloop

endif.

endloop

or better way to do

Re: loop in loop performance

Former Member — Thu, 20 Dec 2012 17:38:25 GMT

Yes, you already have an answer. Second method is better.

It is called parallel cursor method. You can search forum for more details.

What is your question exactly?

Re: loop in loop performance

Former Member — Thu, 20 Dec 2012 17:39:32 GMT

Please dont post duplicate threads.

http://scn.sap.com/thread/3283423

Re: loop in loop performance

Former Member — Fri, 21 Dec 2012 07:07:48 GMT

hi sory for double posting ı forgot

thanks by the way

Re: loop in loop performance

ThomasZloch — Fri, 21 Dec 2012 13:56:01 GMT

Parallel cursor method is largely obsolete since you can declare your internal tables as SORTED.

In your similar but not exact example, you should declare ITABIN TYPE SORTED TABLE OF ... WITH ... KEY MATNR LGORT.

Read ABAP documentation for more details.

Thomas

Re: loop in loop performance

ravi_lanjewar — Fri, 21 Dec 2012 19:24:00 GMT

User the sorted table for inner loop.

Change the defination of internal table as

Data: itabin type sorted table of ty_itabin with non-unique key matnr lgort.

below given logic will give the better performance over the parallel cursor method. Parallel cursor method is old and obsolate way of handling the loop within loop.

You can also used the fields symbol insted of work area.

loop at itabin where matnr eq itabex-matnr

and lgort eq itabex-lgort

endloop

endloop.

For more details plz search on scn for key word "Sorted table"

Re: loop in loop performance

Former Member — Sat, 22 Dec 2012 03:32:18 GMT

Parallel cursor method is obsolete? Are you comparing 4.7 and ECC6? I had used it in 4.7 and it worked.

I had more than 1000 entries in both tables and parallel cursor method was the only thing that worked.

Has this issue been addressed in ECC6? I doubt. I had faced the same issue while working on ECC6 as well.

Yes for table entries ranging from 100 to 500, it does not improve performance.

Also, you are sorting on the key fields I guess. I think it works in case you have more fields in table structure and a where clause on non-key fields.

Re: loop in loop performance

Former Member — Sat, 22 Dec 2012 08:30:23 GMT

okey thanks ı have a great deal of data ı will test both technique I think it will show me the differance

Re: loop in loop performance

ThomasZloch — Sat, 22 Dec 2012 15:13:47 GMT

It's obsolete in a sense that it is unnecessarily complex, by using sorted tables (declared as TYPE SORTED) for the inner loop you achieve similar performance but have more straightforward code. KISS principle. From 702 you can even declare secondary keys for internal tables, in case several access paths are required.

Thomas

Re: loop in loop performance

Former Member — Thu, 27 Dec 2012 10:53:36 GMT

Hello,

Instead of using Loop inside loop .

You can use join query to get data from two different table and create single internal table.
This will get executed fast as compare to loop inside loop.

this is what i think.

Regards,

Re: loop in loop performance

Former Member — Thu, 27 Dec 2012 11:29:26 GMT

sorted table is the fastest method ı tried it

thanks folks