topic Re: Form Routine calling itself in Application Development and Automation Discussions

Form Routine calling itself

Former Member — Wed, 27 Apr 2011 14:46:25 GMT

I would like to know what the perfomance issues if any the following code would cause:

select single matnr

from mean

into lv_matnr

where ean11 = lv_ean11

and eantp = 'UC'. "#EC *

if sy-subrc = 0. " If Same UPC existed / assigned to material then generate next UPC number

perform GET_NEXT_NUMBER. " Get Next number in the same number range

else.

V_UPC = lv_upc_chk.

endif.

The issue is that this code is in the form routine GET_NEXT_NUMBER and if the select to MEAN is successful it calls itself. If this happens many times wouldn't this have a negative effect on performance?

Re: Form Routine calling itself

former_member191735 — Wed, 27 Apr 2011 14:58:28 GMT


> I would like to know what the perfomance issues if any the following code would cause:
> 
> select single matnr
>                        from mean
>                        into lv_matnr
>                       where ean11 = lv_ean11
>                         and eantp = 'UC'.      "#EC *
>               if sy-subrc = 0.                 " If Same UPC existed / assigned to material then generate next UPC number
>                  perform GET_NEXT_NUMBER.  " Get Next number in the same number range
>               else.
>                  V_UPC = lv_upc_chk.
>               endif.
> 
> The issue is that this code is in the form routine GET_NEXT_NUMBER and if the select to MEAN is successful it calls itself.  If this happens many times wouldn't this have a negative effect on performance?

Unless you change lv_ean11 - This will be endless loop. Forget about performance but think about getting out from the routine.

if the value is changed then that is ok if it serves the purpose. This is a recursive call and cannot be eliminated if required.

Re: Form Routine calling itself

Former Member — Wed, 27 Apr 2011 15:05:08 GMT

Agreed. I should have included the code above this section where the NUMBER_GET_NEXT FM is called to build the next lv_ean11(UPC number) value used in the select. This process will continue until a matching UPC number is not found in MEAN.

Re: Form Routine calling itself

former_member191735 — Wed, 27 Apr 2011 15:09:18 GMT

that's alright, If you cannot eliminate the recursive call. as far as i know, there is no alternate to recursive