topic Re: automatic generation of ABAP-classes from Function Groups? in Application Development and Automation Discussions

automatic generation of ABAP-classes from Function Groups?

joachimrees1 — Mon, 01 Nov 2010 13:17:27 GMT

Hey there,

is there a way of having (SE24)-ABAP-Classes generatetd outomaticaly by providing an existing function group?

I think, the following mapping shold be possible::

- the function group is the class

- its function modules are public (static) methods

- any form-routines are private methods

...

-> I don't want to to that boring work myself, some tool should be able to do that just fine, right? So, is there such a tool?

Thanks, regards

Joachim

Re: automatic generation of ABAP-classes from Function Groups?

Former Member — Mon, 01 Nov 2010 13:35:51 GMT

I don't think there's a tool to transfer a function group to a class automatically

Which is your issue?

Max

Re: automatic generation of ABAP-classes from Function Groups?

Former Member — Mon, 01 Nov 2010 16:20:44 GMT

I suspect also as Max that there is no such tool. Apart from few technical difficulties for a general translation (e.g. the one thing that immediately comes to mind is the global function interfaces, i.e. where all parameters are global) I don't see why one would want such a tool, because it seems a bit silly...

I don't quite see what one would gain by such a translation, especially considering the fact that most function groups are probably not really representing any class/object. So I'd expect such automated translation to result (in most cases) in poor OO design. This should be especially true for function groups that are heavily used, because in those cases an automated translation most likely should create only static methods/attributes (to also support the easy and possibly automated replacement of function calls with method calls).

Anyhow, I have a hard time seeing why one would want to do such thing. My wild guess would be that you're working for some client who's fallen for SAP's ABAP OO craze that labels any non-OO ABAP as obsolete (except for some special cases like RFC's, classic dynpro programming, etc.). I don't think that's appropriate, because good design doesn't necessarily require OOP. So if that's what triggered your question, I think it would be best to explain the client a little bit about good development/design principles. My apologies for this little rant, but I couldn't resist - maybe others post something more useful with respect to your original question...

Cheers, harald

Re: automatic generation of ABAP-classes from Function Groups?

joachimrees1 — Tue, 02 Nov 2010 12:33:04 GMT

Max, Harald,

thank you very much for your input;

My issue is that:

I implemented some functionality using a function-module (in a fuction group) with some perform-calls in int.

When I was finished, I realized I'd rather have a static method (in a global class), with some method-calls in it.

(Doing the very same thing; I had used the "old" technology just out of habit).

I know that there is some "Migration tool" to convert SapScript-Forms to Smartforms (not very usefullt I think, but they exist) so I thought maybe there's something similar for "Function Group to Class" (as I pointed out, it should be technically possible ( maybe with exceptions) - not to have a finished, 100% working and perfectly designed class, but to save the manuel work such a transition would take to do "by hand").

So, Harald, you pretty much got the point: I want just something looking "OOish", doing just what my function module does!

Re: automatic generation of ABAP-classes from Function Groups?

Former Member — Tue, 02 Nov 2010 13:34:19 GMT

The only solution is the next time you should develop your functionalities in OO-ABAP instaed of classic ABAP

Just as Harald said, there are big technical difficulties because OO and classic ABAP are based on two different programming philosophies, so I don't believe I can make a sense a tool like that.

The proplem (but it's a problem of our head because we've learned to program using a classic language) it think a static class as a function group, I don't think this is a correct approach, but it could be the base from starting.

Max

Re: automatic generation of ABAP-classes from Function Groups?

Former Member — Tue, 02 Nov 2010 18:34:18 GMT

Sorry, sounds like the only two people who answered are not aware of such a tool...

There is one additional point, which I hadn't thought about initially. With ABAP OO you also have a much stricter syntax and many more statement variants that are obsolete and thus cannot be used. This is another hindrance for writing such a tool (but of course not impossible, I just kind of doubt that any reasonable programmer would write such a thing).

Anyhow, I never understood why SAP is pushing OO so much (declaring all non-OO as obsolete), even going as far as implementing stricter syntax checks for OO. In my opinion a much better option would've been to implement some flag that switches on the more strict syntax checks, similarly to the Unicode check they've introduced. Coding in OO or non-OO, both have its use. Rules from SAP to code everything in OO even in cases where OO doesn't work seems straight silly as a general recommendation: E.g. if I have to code an RFC module, why would I want to bloat my code by introducing a class for implementing the functionality so that the RFC is just a wrapper around the class (unless the additional class gives me some real benefit)?

As much as I appreciate using OO classes supplied by SAP, I often have difficulties seeing objects in the requirements that I have to code (which might of course just be a reflection of my programming skills). A class with just some static methods is often an indication of poor OO design, i.e. there is no reasonable/tangible object and all you have is a utility class with a collection of various methods. To me it's important that the code is well structured, doesn't have any side effects, etc. This can be achieved with non-OO coding as well as OO, but switching from non-OO to OO doesn't guarantee at all that the code is any better.

In the end, if you just have a single function group, I'd recommend to do the translation manually and try to apply good OO design principles (instead of a straightforward 1-to-1 translation). E.g. for a class with just static methods (which I'd expect an automated translation would result in) one might want to take a peek at [singletons are evil|http://www.c2.com/cgi/wiki?SingletonsAreEvil] versus [singletons are good|http://www.c2.com/cgi/wiki?SingletonsAreGood]. I know it's silly advice if you're a seasoned OO programmer; but if not, I think your time is much better spent by thinking about the design and then applying it instead of using some automated tools where you'd later have to anyhow do some refactoring...

Re: automatic generation of ABAP-classes from Function Groups?

joachimrees1 — Mon, 08 Nov 2010 16:40:22 GMT

ok, thank's thanks for your input!

looks like the answer is: "no, there is no such thing".

(so i'll have to convert it by hand or just stick with my function module)