topic Re: modify statement in Application Development and Automation Discussions

modify statement

Former Member — Tue, 21 Sep 2010 10:25:01 GMT

how to modify a standard table using MODIFY statement in abap??

i have used the following statement but it is not working.

data : wa type kna1.

case su-ucomm.

when 'SUBMIT'.

select single * from kna1 into wa where kunnr = kna1-kunnr.

read table i_kna1 with key kunnr = kna1-kunnr.

if sy-subrc = 0 .

modify kna1 from wa.

endcase.

can anybody suggest me anything.

resma

Re: modify statement

Former Member — Tue, 21 Sep 2010 10:30:19 GMT

search is sdn,,,,,,

Re: modify statement

Sandeep_Panghal — Tue, 21 Sep 2010 10:31:00 GMT

read table i_kna1 with key kunnr = kna1-kunnr.

if sy-subrc = 0 .

modify kna1 from wa.

endcase.

I do not see anything modified here ...

Re: modify statement

Former Member — Tue, 21 Sep 2010 10:31:09 GMT

Hello,

First of all you need to use COMMIT WORK after the Modify statement. Also, it is advisable to use where clause after MODIFY statement.

Hope this helps,

Regards,

Himanshu

Re: modify statement

Former Member — Tue, 21 Sep 2010 10:40:24 GMT

data : wa type kna1.

case sy-ucomm.

when 'BACK'.

leave program .

when 'SUBMIT'.

select single * from kna1 into wa where kunnr = kna1-kunnr.

if sy-subrc = 0 .

modify kna1 from wa.

commit work.

endif.

endcase.

endmodule.

i am doing it through a screen.

is this the correct format.

can u advise me.

Re: modify statement

Former Member — Tue, 21 Sep 2010 10:46:07 GMT

Hi,

Modify statement without "WHERE" clause will not work in case of "READ TABLE" (as in your code), it will work only with the "LOOP" statement.

For the "READ TABLE" try using the Modify statement with "TRANSPORTING" and "WHERE" clause. To know the correct syntax press F1 on Modify statment.

Hope this may be helpful.

Regards,

Sharin.

Re: modify statement

Former Member — Tue, 21 Sep 2010 10:50:00 GMT


> Hi,
> 
> Modify statement without "WHERE" clause will not work in case of "READ TABLE" (as in your code), it will work only with the "LOOP" statement.
> 
> For the "READ TABLE" try using the Modify statement with "TRANSPORTING" and "WHERE" clause. To know the correct syntax press F1 on Modify statment.
> 
> Hope this may be helpful.
> 
> 
> Regards,
> Sharin.

MODIFY KNA1 FROM WA definitely works as long as WA has the same structure. No need for a WHERE. And to add: he's updating the database table KNA1 and not some internal table.

@OP: study the F1 on MODIFY.

Re: modify statement

Former Member — Tue, 21 Sep 2010 10:59:57 GMT

Hi,

modify kna1 from wa.

Hope you are not executing this statement in Production Server.

Regards

Vinod

Re: modify statement

Former Member — Tue, 21 Sep 2010 11:21:08 GMT

Use Commit statement after Modify statement.

As Modify statement inserts/overwrites a record so please specify the specific record number in where clause.

Regards,

Amit

Re: modify statement

Former Member — Tue, 21 Sep 2010 11:28:34 GMT


> Hi,
> 
> modify kna1 from wa.
> 
> Hope you are not executing this statement in Production Server.
> 
> Regards
> Vinod

Judging by his code, he won't be changing anything.

selection into WA, but no changes made to WA.

Re: modify statement

Former Member — Tue, 21 Sep 2010 11:28:45 GMT

Hi,

Modifing a standard table from SAP and doing that the way you propose, can result in loosing support from SAP. Never modify standard SAP tables unless doing it via BAPI's provided by SAP.

Please have a look at BAPI:

SD_CUSTOMER_MAINTAIN_ALL

Many others are available too.

Best regards,

Guido Koopmann

Re: modify statement

Former Member — Tue, 21 Sep 2010 11:28:49 GMT

Hi,

I wrongly assumed it as an internal table instead of database table. As Maen said, there is no need of "WHERE" in case of database updation as long as WA has the same structure.

Since it is a database updation, use "COMMIT WORK".

Maen,

Thanks for correcting.

Regards,

Sharin.

Re: modify statement

Former Member — Tue, 21 Sep 2010 11:33:16 GMT

This message was moderated.

Re: modify statement

matt — Tue, 21 Sep 2010 11:50:59 GMT


> Hi,
> 
> Modifing a standard table from SAP and doing that the way you propose, can result in loosing support from SAP.  Never modify standard SAP tables unless doing it via BAPI's provided by SAP.
> 
> Please have a look at BAPI:
> SD_CUSTOMER_MAINTAIN_ALL
> 
> Many others are available too.
> 
> Best regards,
> 
> Guido Koopmann

So important I thought I'd mention it again.

Modifing a standard table from SAP and doing that the way you propose, can result in loosing support from SAP. Never modify standard SAP tables unless doing it via BAPI's provided by SAP.

Re: modify statement

Former Member — Wed, 22 Sep 2010 09:20:57 GMT

agree with MATT instead of modify statement u can use BAPI

Edited by: kk.adhvaryu on Sep 22, 2010 11:21 AM