topic Re: Modify statement not working in Application Development and Automation Discussions

Modify statement not working

Former Member — Thu, 12 Aug 2010 09:52:00 GMT

Hi All,

I am using a modify statement in my report to update a 'Z' table , SY_SUBRC is returned as 0 but data is not updated.

MODIFY znc_gdsh FROM wa_znc_gdsh.

Any idea why data is not updated?

Thanks in Advance.

Re: Modify statement not working

Former Member — Thu, 12 Aug 2010 09:55:53 GMT

Hi,

Check if it is overwriting same record.

Regards,

Harsh.

Re: Modify statement not working

Former Member — Thu, 12 Aug 2010 09:56:16 GMT

use commit work after modify statement

Thanks

Bala Duvvuri

Re: Modify statement not working

Former Member — Thu, 12 Aug 2010 09:56:40 GMT

Hello

COMMIT WORK will help you.

Re: Modify statement not working

Former Member — Thu, 12 Aug 2010 09:56:44 GMT

Hi,

wa_znc_gdsh is only work area or internal table?

Yo can use the synatx as belwo also.


  DATA: it_znc_gdsh TYPE STANDARD TABLE OF znc_gdsh.

  MODIFY  znc_gdsh FROM TABLE it_znc_gdsh.

  IF sy-subrc = 0.
    COMMIT WORK.
  ENDIF

Regards,

Pravin

Edited by: pravin s. on Aug 12, 2010 11:57 AM

Re: Modify statement not working

Former Member — Thu, 12 Aug 2010 09:58:21 GMT

Hi,

Check if your are updating with the same work area into which the data s being collected. There is every chance of making such minor mistakes

Dev.

Re: Modify statement not working

Former Member — Thu, 12 Aug 2010 09:58:47 GMT

It is not overwriting same record.

Re: Modify statement not working

Former Member — Thu, 12 Aug 2010 10:01:47 GMT

Before modify statement, I am able to see the updated data in the work area. but after modify, new values dont get updated into the data base table.

Re: Modify statement not working

Former Member — Thu, 12 Aug 2010 10:05:22 GMT

Hi,

Can you paste your program snippet here.\

Regards,

Harsh.

Re: Modify statement not working

Former Member — Thu, 12 Aug 2010 10:05:52 GMT

Hi,

Try to add option TRANSPORTING...

Re: Modify statement not working

Former Member — Thu, 12 Aug 2010 10:11:10 GMT

{ LOOP AT t_rept INTO v_rept FROM 2

WHERE si_002(2) NE '--'

AND si_004(2) NE '--'.

CLEAR wa_znc_gdsh.

MOVE-CORRESPONDING v_rept TO wa_znc_gdsh.

wa_znc_gdsh-si_007 = v_rept-si_007.

wa_znc_gdsh-matnr = v_rept-si_315.

wa_znc_gdsh-langu = v_rept-si_005.

wa_znc_gdsh-vkorg = p_vkorg.

wa_znc_gdsh-meinh = v_rept-si_003.

wa_znc_gdsh-aedat = sy-datum.

wa_znc_gdsh-aezet = sy-uzeit.

wa_znc_gdsh-aenam = sy-uname.

READ TABLE i_gdsh WITH KEY matnr = v_rept-si_315

langu = v_rept-si_005

meinh = v_rept-si_003

si_001 = v_rept-si_001

BINARY SEARCH.

IF sy-subrc = 0.

wa_znc_gdsh-erdat = i_gdsh-erdat.

wa_znc_gdsh-erzet = i_gdsh-erzet.

wa_znc_gdsh-ernam = i_gdsh-ernam.

ELSE.

wa_znc_gdsh-erdat = sy-datum.

wa_znc_gdsh-erzet = sy-uzeit.

wa_znc_gdsh-ernam = sy-uname.

ENDIF.

MODIFY znc_gdsh FROM wa_znc_gdsh.

Endloop.}

Re: Modify statement not working

Former Member — Thu, 12 Aug 2010 10:29:39 GMT

Hi ,

Check are you trying to pass the Primary key values same as Database table.

if so chcek the sy-subrc after Modify statement.

and use Commit statement after Modify statemnt.

Regards,

Prabhudas

Re: Modify statement not working

former_member322248 — Thu, 12 Aug 2010 10:30:11 GMT

hi try to append the work area in an internal table, and after the loop, use that internal table for the modify statement, MODIFY z_table from it_tab, double check again if the values you are updating are unique, and you can also try to use the commit work statement after the modify statement. if the return subrc = 0, then it most likely did a change in the table.

Re: Modify statement not working

Former Member — Thu, 12 Aug 2010 10:45:12 GMT

Hi,

Try using modify outside loop and commenting the clear wa.

Regards,

Harsh.

Re: Modify statement not working

Former Member — Thu, 12 Aug 2010 10:58:45 GMT

Hi,

Try below code..

{ LOOP AT t_rept INTO v_rept FROM 2

WHERE si_002(2) NE '--'

AND si_004(2) NE '--'.

v_tabix = sy-tabix.

MOVE-CORRESPONDING v_rept TO wa_znc_gdsh.

wa_znc_gdsh-si_007 = v_rept-si_007.

wa_znc_gdsh-matnr = v_rept-si_315.

wa_znc_gdsh-langu = v_rept-si_005.

wa_znc_gdsh-vkorg = p_vkorg.

wa_znc_gdsh-meinh = v_rept-si_003.

wa_znc_gdsh-aedat = sy-datum.

wa_znc_gdsh-aezet = sy-uzeit.

wa_znc_gdsh-aenam = sy-uname.

READ TABLE i_gdsh WITH KEY matnr = v_rept-si_315

langu = v_rept-si_005

meinh = v_rept-si_003

si_001 = v_rept-si_001

BINARY SEARCH.

IF sy-subrc = 0.

wa_znc_gdsh-erdat = i_gdsh-erdat.

wa_znc_gdsh-erzet = i_gdsh-erzet.

wa_znc_gdsh-ernam = i_gdsh-ernam.

ELSE.

wa_znc_gdsh-erdat = sy-datum.

wa_znc_gdsh-erzet = sy-uzeit.

wa_znc_gdsh-ernam = sy-uname.

ENDIF.

MODIFY znc_gdsh FROM wa_znc_gdsh INDEX v_tabix.

CLEAR wa_znc_gdsh.

clear v_rept.

Endloop.}

Regards,

Raj.

Re: Modify statement not working

Former Member — Thu, 12 Aug 2010 11:29:23 GMT

Hi,

Replace your modify with.

MODIFY znc_gdsh FROM wa_znc_gdsh TRANSPORTING erdat erzet ernam.

Regards,

Gunjan.

Re: Modify statement not working

Former Member — Thu, 12 Aug 2010 11:48:51 GMT

not working

Re: Modify statement not working

Former Member — Thu, 12 Aug 2010 12:23:52 GMT

Check for your table keys properly.

Regards,

Sai Prasad

Re: Modify statement not working

Former Member — Thu, 12 Aug 2010 12:41:09 GMT

Hi,

Check the below code it works:

DATA : lt_vbak TYPE STANDARD TABLE OF vbak.

DATA : lwa_vbak LIKE LINE OF lt_vbak.

SELECT vbeln erdat erzet ernam

UP TO 2 ROWS INTO CORRESPONDING FIELDS OF TABLE lt_vbak

FROM vbak.

LOOP AT lt_vbak INTO lwa_vbak.

IF lwa_vbak-erdat <> sy-datum AND lwa_vbak-erzet <> sy-uzeit.

lwa_vbak-erdat = sy-datum.

lwa_vbak-erzet = sy-uzeit.

MODIFY lt_vbak FROM lwa_vbak TRANSPORTING erdat erzet.

ENDIF.

ENDLOOP.

MODIFY vbak FROM TABLE lt_vbak.

IF sy-subrc = 0.

COMMIT WORK.

ENDIF.

Regards,

Gunjan

Re: Modify statement not working

Former Member — Thu, 12 Aug 2010 12:56:26 GMT

Hi,

Try using Insert and Update statements and check if they are working.

Thanks,

Venkat