topic Re: Code taking too much time to output in Application Development and Automation Discussions

Code taking too much time to output

Former Member — Mon, 05 Apr 2010 06:52:29 GMT

Following code is taking too much time to execute . (some time giving Time_out )

ind = sy-tabix.

SELECT SINGLE * FROM mseg INTO mseg

WHERE bwart = '102' AND

lfbnr = itab-mblnr AND

ebeln = itab-ebeln AND

ebelp = itab-ebelp.

IF sy-subrc = 0.

DELETE itab INDEX ind.

CONTINUE.

Is there any other way to write this code to reduce the output time.

Thanks

Re: Code taking too much time to output

Former Member — Mon, 05 Apr 2010 06:58:01 GMT

Why dont you select all the data from MSEG once??? Outside the loop

SELECT * FROM mseg INTO mseg

WHERE bwart = '102'.

sort mseg.

Now Read table mseg where mseg = itab-mblnr AND

ebeln = itab-ebeln AND

ebelp = itab-ebelp Binary Search.

This might work in a lesser time

Re: Code taking too much time to output

Former Member — Mon, 05 Apr 2010 07:11:27 GMT

Hi,

u can select what are all the field s u need to display in out put screen instead of taking all fields from the MSEG,

(other wise try UPTO ONE ROW statement .)

thanks

Re: Code taking too much time to output

Former Member — Mon, 05 Apr 2010 07:12:30 GMT

Hi,

I think you are executing this code in a loop which is causing the problem. The rule is "Never put SELECT statements inside a loop".

Try to rewrite the code as follows:


* Outside the loop
SELECT *
from MSEG
into table lt_mseg
for all entries in itab
where bwart = '102' AND
lfbnr = itab-mblnr AND
ebeln = itab-ebeln AND
ebelp = itab-ebelp.

Then inside the loop, do a READ on the internal table


Loop at itab.

*******

read table lt_mseg with key bwart = '102'. "plus other conditions
if sy-subrc ne 0.
delete itab. "index is automatically determined here from SY-TABIX
endif.

******

endloop.

I think this should optimise performance. You can check your code's performance using SE30 or ST05.

Hope this helps! Please revert if you need anything else!!

Cheers,

Shailesh.

Always provide feedback for helpful answers!

Re: Code taking too much time to output

Former Member — Mon, 05 Apr 2010 07:16:57 GMT

Hi,

You can try with creating secondary index with the same combination .It will reduce your time.

Thanks,

Ankita

Re: Code taking too much time to output

Former Member — Mon, 05 Apr 2010 07:18:16 GMT

hi,

i think the problem is that you are extracting the data from the same place and replacing it in the same place in the table....

try putting the extracted data into an internal table first and then use the update statement to update the table with the given data.

Re: Code taking too much time to output

Former Member — Mon, 05 Apr 2010 07:18:22 GMT

Try This

SELECT SINGLE * FROM mseg INTO mseg
WHERE bwart = '102'.

loop at mseg into wa_mseg.
read table itab into wa_itab with key mblnr = wa_mseg-lfbnr
                                      ebeln = wa_mseg-ebeln
                                      ebelp = wa_mseg-ebelp.
if sy-subrc eq 0.
 ind = sy-tabix.
 DELETE itab INDEX ind.
endif.
endloop.

Regards

Vinod

Re: Code taking too much time to output

Former Member — Mon, 05 Apr 2010 08:36:46 GMT

Within standard SAP there's no appropriate index on MSEG to support your query. Thus instead of selecting the material document directly from MSEG via the purchase order number, you should first get the material documents via the purchase order history table EKBE. Then you can read the MSEG data you need using the material document number (mseg-mblnr=ekbe-belnr, mseg-mjahr=ekbe-gjahr, mseg-zeile=ekbe-buzei) or simply use a join on EKBE and MSEG.

This should give you the speed you're looking for...

Cheers, harald

Re: Code taking too much time to output

sivaprasad_ml — Mon, 05 Apr 2010 09:08:59 GMT

Hello,

Try this way.

sELECT SINGLE * FROM mseg INTO mseg

WHERE

lfbnr = itab-mblnr AND

ebeln = itab-ebeln AND

ebelp = itab-ebelp and

bwart = '102'.

IF sy-subrc = 0.

DELETE itab INDEX ind.

CONTINUE.

This may help out.

Rgds

Siva

Re: Code taking too much time to output

sivaprasad_ml — Mon, 05 Apr 2010 09:11:45 GMT

I welcome Mr Harold's suggestion too. You can try with that too.

Cheers

Siva

Re: Code taking too much time to output

Former Member — Mon, 05 Apr 2010 11:52:46 GMT

Hi sir, I tried your idea like

LOOP AT itab.

ind = sy-tabix.

SELECT SINGLE * FROM mseg INTO mseg

WHERE bwart = '102'.

loop at mseg .

read table itab with key bwart = '102'

mblnr = mseg-lfbnr

ebeln = mseg-ebeln

ebelp = mseg-ebelp binary search.

IF sy-subrc ne 0.

DELETE itab INDEX ind.

endif.

endloop.

It increase the performance but it is not deleting itab for condition bwart 102. Please do check me , what m doing wrong ?

Thanks

Re: Code taking too much time to output

Former Member — Mon, 05 Apr 2010 13:06:18 GMT


>  Please do check me , what m doing wrong ?

Moderator message - Please see before posting - post locked