topic Re: code optimization in Application Development and Automation Discussions

code optimization

Former Member — Wed, 03 Feb 2010 07:37:05 GMT

I have the code as below:

SELECT MATNR

FROM MARA

INTO TABLE IT_MARA

WHERE MTART = 'FERT'.

LOOP AT IT_MARA INTO WA_MARA.

SELECT MAKTX matnr FROM MAKT INTO TABLE IT_MAKT

WHERE MATNR = WA_MARA-MATNR.

LOOP AT IT_MAKT INTO WA_MAKT.

APPEND WA_MAKT to IT_MAKT.

ENDLOOP.

when i run this code i get the following error "No more storage space available for extending an internal table".

please suggest how can i optimise the code.

Re: code optimization

Former Member — Wed, 03 Feb 2010 07:39:00 GMT

You need to get trained in ABAP. Seriously.

Re: code optimization

former_member329859 — Wed, 03 Feb 2010 07:39:47 GMT

This message was moderated.

Re: code optimization

Former Member — Wed, 03 Feb 2010 07:41:04 GMT


> hi
> LOOP AT IT_MARA INTO WA_MARA.
> SELECT MAKTX matnr FROM MAKT INTO TABLE IT_MAKT
> WHERE MATNR = WA_MARA-MATNR.
> 
> use into corresponding field of the table it_makt after checking your table defination for table it_makt
> 
> thanx
> gaurav

And this would "optimize the code"?

Re: code optimization

Former Member — Wed, 03 Feb 2010 07:42:52 GMT

This message was moderated.

Re: code optimization

Former Member — Wed, 03 Feb 2010 07:53:19 GMT

Hi Ashu ,

You should take some tutorial related with basics and performance tuning.

There are many posts avaliable on SDN related to these.

Press F1 on for all entries to know an alternate approach for your logic.

Hope this helps you.

Re: code optimization

Former Member — Wed, 03 Feb 2010 07:56:40 GMT

Hi,

Please check

SELECT MATNR
FROM MARA
INTO TABLE IT_MARA
WHERE MTART = 'FERT'.

if sy-subrc eq 0 and it_mara is not initial.

SELECT MAKTX matnr FROM MAKT FOR ALL ENTRIES IN IT_MARA INTO TABLE IT_MAKT
WHERE MATNR = IT_MARA-MATNR.

endif.

what this loop statement is doing.

LOOP AT IT_MAKT INTO WA_MAKT.

APPEND WA_MAKT to IT_MAKT.

ENDLOOP.

Is that you need to populate the internal table with a material and its corresponding material descriptions. ?

thanks,

Re: code optimization

RaymondGiuseppi — Wed, 03 Feb 2010 08:06:09 GMT

Read what you have written

LOOP AT IT_MAKT INTO WA_MAKT.
APPEND WA_MAKT to IT_MAKT.
ENDLOOP.

No, read it actually

Regards,

Raymond

Re: code optimization

SuhaSaha — Wed, 03 Feb 2010 08:10:01 GMT

ROFL ...

Re: code optimization

RaymondGiuseppi — Wed, 03 Feb 2010 08:12:07 GMT

More seriously, the question, was "When will the LOOP terminate ?"

The answer, is when no more memory or time out is reached...

Regards,

Raymond

Re: code optimization

SuhaSaha — Wed, 03 Feb 2010 08:18:18 GMT

Hello Raymond,

I had got it the first time you had mentioned

Cheers,

Suhas

Re: code optimization

Former Member — Wed, 03 Feb 2010 08:36:53 GMT

Hi,

For Optimising,

1st) Instead of first loop use Select For All Enteries (query)

2nd) Avoid calling select queries from inside of a loop, its not a good pratice.

3rd) regarding the dump error, contact your BASIS for memory settings of SAP.

Thanks!