topic Re: issue with loop in table control in Application Development and Automation Discussions

issue with loop in table control

Former Member — Wed, 28 Oct 2009 07:44:09 GMT

Hello experts,

I have 20 entries in my table control but the loop is going through only for 10 entries..please help me?

Thanks

Re: issue with loop in table control

Former Member — Wed, 28 Oct 2009 07:54:54 GMT

Hi,

first update the table of 20 entries from your displayed table,

and loop over your global variable with the 20 lines.

Greetz,

Koen

Re: issue with loop in table control

MarcinPciak — Wed, 28 Oct 2009 07:57:20 GMT

The loop is going only this number of times, how many lines are set to be visible (table control height). So whenever you scroll down new records willl be processed. If you want entire table to be processed within one loop, simply extend your tablec control to fit 20 records at once. In your case only 10 are visibile at a time.

Regards

Marcin

Re: issue with loop in table control

Former Member — Wed, 28 Oct 2009 07:59:03 GMT

In PBO

module status_your_screen_number.

loop at itab with control tc.

endloop.

in PAI.

loop at itab.

module modify_itab

endloop.

in Program

Module status_your_screen_Number.

describe table itab lines tc-lines -

> THis will give you Scroll Bars for Table Control

endmodule

module modify_itab. -

> If Required ( If you are modifying the Data of table control )

DESCRIBE TABLE itab LINES lin.

IF tc-current_line > lin.

APPEND itab.

ELSE.

MODIFY itab INDEX tc-current_line. ---> This Ensures your data both Upward And Downward Scrolling

ENDIF.

endmodule

Cheers

Ram

Edited by: Ramchander Krishnamraju on Oct 28, 2009 8:59 AM

Edited by: Ramchander Krishnamraju on Oct 28, 2009 9:26 AM

Re: issue with loop in table control

Former Member — Wed, 28 Oct 2009 08:20:19 GMT

yeah visible entries are 10 but there are 20 entries sometimes its going to be 100 entries, how to overcome this issue , i want to process all the entries

Re: issue with loop in table control

Former Member — Wed, 28 Oct 2009 08:25:49 GMT

Hi,

Store your general table in a global variable in your program,

in the PBO you loop over the general table, updating from the displayed table.

Then you loop over the general variable

grtz,

Koen

Re: issue with loop in table control

Former Member — Wed, 28 Oct 2009 08:37:46 GMT

Hi Labie , thanks for your reply but i think you answering how to upload the data in table control.I can upload my 20 entries in it but the the thing is its just looping over 10 times ..But i wanna loop over up to number of entries...plz help..

Re: issue with loop in table control

Former Member — Wed, 28 Oct 2009 08:40:44 GMT

Hi,

I was mistaken, PBO should be PAI

but same thing goes

grtz,

Koen

Re: issue with loop in table control

MarcinPciak — Wed, 28 Oct 2009 08:45:32 GMT

System automatically restricts looping over entire table, as there can be i.e. couple thousands of entires in table, and as you display 10 of them there is no point to create additional load for system looping over all entries. The ones which are displayed are assumed by system to be the ones you are intertested in. Whenever you loop over table control together with table which holds data for it, it will always restrict this loop to number of visible entires. What do you really need to loop ovew entire table for?

You can also suppress looping over internal table and just loop over table control. Later in called module you read/update respective entry in table. Example program for it DEMO_DYNPRO_TABCONT_LOOP

Regards

Marcin

Re: issue with loop in table control

Former Member — Wed, 28 Oct 2009 08:53:51 GMT

Marcin is right

You need to consider you have two different tables: internal table with all items to be managed and control table with the items can be displayed only.

That means the table control can loop the items displayed only.

If you need to loop all records, u need to repeat a new loop outside the LOOP of PBO and PAI, anyway if you say what u need to do, perhaps we can give you a solution.

Max

Re: issue with loop in table control

RaymondGiuseppi — Wed, 28 Oct 2009 09:19:02 GMT

You have to loop twice

- First in, the PAI LOOP AT <itab> will only loop thru displayed lines, there you may perform checks and don't forget to update the itab in the main program

- Then execute an other Module outside of the LOOP/ENDLOOP and there you may LOOP thru the full program internal table.

* TOP include

CONTROLS: ctrl TYPE TABLEVIEW USING SCREEN nnnn.
DATA: itab TYPE TABLE OF work.

* Dynpro nnnn PAI

PROCESS AFTER INPUT. 
  LOOP AT itab INTO work. 
      FIELD work-field1
      MODULE linecheck.
      MODULE lineupdate.
  ENDLOOP.
  MODULE fullitab.

* Include of PAI modules

MODULE lineupdate INPUT.
    MODIFY itab FROM work INDEX ctrl-current_line.
ENDMODULE.

MODULE fullitab INPUT.
  LOOP AT itab INTO work.
    " here your code
  ENDLOOP.  
ENDMODULE.

So user may correct the displayed lines, and your program can send error for lines not displayed. (if there are errors before any input from user ?)

Regards,

Raymond

Re: issue with loop in table control

Former Member — Wed, 28 Oct 2009 13:59:59 GMT

Hi Max ,

To start with How system knows if there are valid entries or invalid entries until it does some validation, to validate it should loop through all entries in my table control.But its just doing 10 no matter if they are valid ones or invalid ones.plz help

thanks

Re: issue with loop in table control

Former Member — Wed, 28 Oct 2009 14:25:13 GMT

Something sounds bad for me, because it should does the validations only for the new and changed records, and i.e. for the records displayed by table control only.

So why do u need to check all entries?

Max

Edited by: max bianchi on Oct 28, 2009 3:32 PM

Re: issue with loop in table control

former_member191735 — Wed, 28 Oct 2009 14:29:54 GMT


> Hi Max ,
> To start with How system knows if there are valid entries or invalid entries until it does some validation, to validate it should loop through all entries in my table control.But its just doing 10  no matter if they are valid ones or  invalid ones.plz help
> 
> thanks

Do this under PAI

loop with control tc_abc. " This will loop through your control which means, through all records.

module update_inttable.

endloop.

The module code should be like this

modify it_abc from wa_abc index tc_abc-current_line.

What that will do? this will update your internal table it_abc from the table control.

for you validations.....

there is a module called user_command_1XX (Screen number).

On sy-ucomm or whatever the variable....

do your validations by looping through your internal table into work area....

Re: issue with loop in table control

Former Member — Wed, 28 Oct 2009 14:32:21 GMT

Hi sampath,

Well I can do that way for validation...so if i have 20 deliveries and they all valid...its still doing 10 times , how to get over this?

Thanks

Re: issue with loop in table control

Former Member — Wed, 28 Oct 2009 14:43:55 GMT

* Do this under PAI

loop with control tc_abc. " This will loop through your control which means, through all records.
module update_inttable.
endloop.

Just as it was written above, the LOOP of table control loops only the records can be displayed at the same time in tc.: that depends on how many rows were designed in tc by screen painter.

If the internal table has 100 records and table control can display 10 records only, the tc will loops a package of 10 records and not all records of the internal table.

The system variables:

- SY-LOOPC returns how many records can be displayed

- SY-STEPL returns the current record

The variable field TOP_LINE of table control returns the record of the internal table placed at the TOP, SY-STEPL can be from 1 to N (N = SY-LOOPC), i.e 10 in my sample, that means the link between the row of table control and the record of internla table will be:

Record Internal table = <table control>-TOP_LINE + SY-STEPL - 1.

This value is stored in fiedl CURRENT_LINE of table control.

Max

Re: issue with loop in table control

Former Member — Wed, 28 Oct 2009 14:46:48 GMT

????

In which program? Standard one?

Max

Re: issue with loop in table control

former_member191735 — Wed, 28 Oct 2009 14:47:39 GMT

Max answered

How about tablecontrol-lines ? this will give the number of records in the table control.

Edited by: Sampath Kumar on Oct 28, 2009 8:49 AM

Edited by: Sampath Kumar on Oct 28, 2009 8:54 AM

Re: issue with loop in table control

Former Member — Wed, 28 Oct 2009 14:59:15 GMT

tablecontrol-lines has the total of rows have to be displayed in table control, that means is equal to the number of records loaded in table control.

Sometimes the system can't calculated it, and the effect is the vertical scroll bar is missing, so sometime a module in PBO (just before the LOOP of table control) can be placed in order to fill it:

DESCRIBE TABLE ITAB LINES <TABLE CONTROL-LINES>.

Max