topic Re: Procedural-2-OOPS in Application Development and Automation Discussions

Procedural-2-OOPS

Former Member — Mon, 24 Aug 2009 16:20:47 GMT

Hello experts,

I want to rebuild a procedural report to object oriented, can some one tell me which steps i have to do , to redesign it ?

My Report Structure is :

*Structured Types*    


TYPES:BEGIN OF ty_projnum,
             prj_num    TYPE zprojectmst-prj_num,
             prj_name   TYPE zprojectmst-prj_name,
             cat_num    TYPE zprojectcard-cat_num,
       END OF ty_projnum.*
 

TYPES:BEGIN OF    ......
 



  END OF
 

DATA: ........
 


**---------------------------------------------------------------------**
**       Select Options                          **
**---------------------------------------------------------------------**

*..*

**----------------------------------------------------------------------**
 
**     AT SELECTION-SCREEN*
 
**----------------------------------------------------------------------**
 
*...*
 
**---------------------------------------------------------------------**
 
**             S T A R T   O F   S E L E C T I O N                     **
 
**---------------------------------------------------------------------**
 
*...*
 
*with reforms*
 
*..*

Edited by: Matt on Sep 7, 2009 9:50 AM - fixed formatting - why was it all BOLD?

Re: Procedural-2-OOPS

Sandra_Rossi — Mon, 24 Aug 2009 19:44:14 GMT

we can't answer as OOPS means an in-depth knowledge of the job done by the program, what you want to reuse, what already exists "outside". You must do it by yourself. Or ask a more precise question.

Re: Procedural-2-OOPS

Former Member — Mon, 24 Aug 2009 21:16:20 GMT

So I am new in ABAP Object World, what i knew from Java World have tried on this case but i dont know if it write .

I maked a Class diagram with some classe what i created for the report.

the qustion here is :

is there some thing calls Report Class ? or a class which can do the same work like a report ?

regards

Re: Procedural-2-OOPS

Sandra_Rossi — Tue, 25 Aug 2009 06:49:33 GMT

In term of OOP, this question makes no sense. Frankly, I recommend you to train on OOP without looking at this program, learn the major notions and make tests with little programs. At the end, you'll better understand if it's worth rewriting your program (there may be no advantage to rewrite it). Have a look at [SDN ABAP Objects section|/docs/DOC-8024#section2 [original link is broken]]

Re: Procedural-2-OOPS

dirk_wittenberg — Fri, 04 Sep 2009 13:16:24 GMT

a possible general structure for your program could be:

report ydemo.

data: g_model type ref to ycl_report_model,

         g_viewer type ref to ycl_report_viewer.

initialization.

  create object g_model.

at selection-screen.

  g_model->set_selections( ... ).

start-of-selection.

  g_model->make_data_selections( ).

end-of-selection.

  create object g_viewer.
  g_viewer->display( g_model ).

YCL_REPORT_MODEL and YCL_REPORT_VIEWER are global classes. The first to select the data, make calculations and so on, the second to display the results.

I hope this helps you,

regards

Dirk

Re: Procedural-2-OOPS

matt — Mon, 07 Sep 2009 07:58:20 GMT

The selection screen (SELECT-OPTIONS, PARAMETERS) however, have to be in a procedural report. So, build on Dirk's code.

report ydemo.
 
data: g_model type ref to ycl_report_model,
 
         g_viewer type ref to ycl_report_viewer.
 
PARAMETERS: p_param TYPE ...

SELECT-OPTIONS: o_sel FOR ...

initialization.
 
  create object g_model.
 
at selection-screen.
 
  g_model->set_selections( i_param = p_param ir_sel = o_sel[] ).
 
start-of-selection.
 
  g_model->make_data_selections( ).
 
end-of-selection.
 
  create object g_viewer.
  g_viewer->display( g_model ).

Within set_selections, I define ir_sel as a STANDARD TABLE. I then use:

FIELD-SYMBOLS: <lr_sel> TYPE STANDARD TABLE.
CREATE DATA me->rr_sel LIKE ir_sel. " rr_sel is an instance attribute of type REF TO DATA
ASSIGN me->rr_sel->* TO <lr_sel>.
<lr_sel> = ir_sel.

In make_data_selections, I do this

FIELD-SYMBOLS: <lr_sel> TYPE STANDARD TABLE.
ASSIGN me->rr_sel->* TO <lr_sel>.

SELECT * FROM table WHERE sel IN <lr_sel>.

matt

Re: Procedural-2-OOPS

nomssi — Mon, 28 Sep 2009 22:25:45 GMT

Advice from Martin Fowler's Refactoring book:

http://sourcemaking.com/refactoring/convert-procedural-design-to-objects

hope this helps,

Jacques Nomssi Nzali

Re: Procedural-2-OOPS

matt — Tue, 29 Sep 2009 05:20:54 GMT

Normally, I'm against single links - but this is a good one. Very relevant.