topic Re: Code in Application Development and Automation Discussions

Code

Former Member — Thu, 13 Aug 2009 15:46:25 GMT

Hi All,

SELECT aufnr INTO afpo-aufnr FROM afpo UP TO 1 ROWS
                   FOR ALL ENTRIES IN itab
                   WHERE aufnr EQ itab-prodorder.
      ENDSELECT.
      IF sy-subrc EQ 0.
        SELECT aufnr posnr wemng
                    INTO CORRESPONDING FIELDS OF TABLE it_afpo
                    FROM afpo
                    FOR ALL ENTRIES IN itab
                    WHERE aufnr EQ itb-prodorder.
        SORT it_afpo BY aufnr.
      ENDIF.

Can I write this in a better way?

Thanks and Regards,

Pooja

Moderator message - Please ask a specific question - post locked

Edited by: Rob Burbank on Aug 13, 2009 12:35 PM

Re: Code

Former Member — Thu, 13 Aug 2009 15:55:13 GMT

yes, you can use pretty print !!!

Re: Code

Former Member — Thu, 13 Aug 2009 16:01:07 GMT

using just one select, u r entry to the same tables twice, so dont u access one time only.

sure that u can writte better,

good luck 😛

Regards

Re: Code

Former Member — Thu, 13 Aug 2009 16:01:58 GMT

if aufnr is the first field in internal table afpo, you could use

 SELECT aufnr INTO TABLE afpo FROM afpo UP TO 1 ROWS
                   FOR ALL ENTRIES IN itab
                   WHERE aufnr EQ itab-prodorder.

This way you'll get rid of the ugly select-endselect.

Re: Code

Former Member — Thu, 13 Aug 2009 16:02:26 GMT

Hi ,

No need of the first select.

Just do like below.

if itab[] is not initial.
        SELECT aufnr posnr wemng
                    INTO CORRESPONDING FIELDS OF TABLE it_afpo
                    FROM afpo
                    FOR ALL ENTRIES IN itab
                    WHERE aufnr EQ itb-prodorder.
        SORT it_afpo BY aufnr.
      ENDIF.

regards,

Ankur Parab

Re: Code

Former Member — Thu, 13 Aug 2009 16:06:13 GMT

Just use one select statement, don't know why you are doing it twice.

      IF itab[] IS NOT INITIAL.
        SELECT aufnr posnr wemng INTO CORRESPONDING FIELDS OF TABLE it_afpo
                                                               FROM afpo
                                                 FOR ALL ENTRIES IN itab
                                                              WHERE aufnr EQ itab-prodorder.
        SORT it_afpo BY aufnr.
      ENDIF.