topic Re: Loop-EndLoop in Application Development and Automation Discussions

Loop-EndLoop

Former Member — Mon, 23 Mar 2009 14:12:16 GMT

Hallo

I have a code for net value. it is working good. But when c_vkdfif-vbtyp = 'K' it dont enter in second loop.

can somebody tell me where is my mistake.

LOOP AT c_vkdfif.
  IF c_vkdfif-vbtyp = 'J' OR ( c_vkdfif-vbtyp = 'T' OR c_vkdfif-vbtyp = 'K' ).
    SELECT a~netwr b~lfimg a~kwmeng INTO CORRESPONDING FIELDS OF TABLE lt_vbap FROM lips AS b
    INNER JOIN vbap AS a ON b~vgbel = a~vbeln AND b~vgpos = a~posnr WHERE b~vbeln = c_vkdfif-vbeln.
    LOOP AT lt_vbap.
      lvx_netwr = ( lt_vbap-netwr / lt_vbap-kwmeng ) * lt_vbap-lfimg.
      lv_netwr  = lv_netwr  + lvx_netwr.
      IF c_vkdfif-vbtyp = 'T'.
        IF lv_netwr > 0 OR lv_netwr = 0.
          lv_netwr  = -1 * lv_netwr.
        ELSE.
          lv_netwr = lv_netwr - lvx_netwr.
        ENDIF.
      ENDIF.
      IF c_vkdfif-vbtyp = 'K'.
        IF lv_netwr > 0 OR lv_netwr = 0.
          lv_netwr  = -1 * ( lv_netwr  + lvx_netwr ).
        ELSE.
          lv_netwr = lv_netwr - lvx_netwr.
        ENDIF.
      ENDIF.
    ENDLOOP.
    c_vkdfif-netwr = lv_netwr.
    MODIFY c_vkdfif.
    CLEAR lv_netwr.
  ENDIF.
ENDLOOP.

Thanks a lot

Waseem.

Edited by: Matt on Mar 23, 2009 4:24 PM - added tags

Re: Loop-EndLoop

Former Member — Mon, 23 Mar 2009 14:17:45 GMT

Hi,

Check this below select statement is returning values or not if c_vkdfif-vbtyp = 'K'

SELECT a_{netwr b}lfimg a~kwmeng INTO CORRESPONDING FIELDS OF TABLE lt_vbap FROM lips AS b

INNER JOIN vbap AS a ON b_{vgbel = a}vbeln AND b_{vgpos = a}posnr WHERE b~vbeln = c_vkdfif-vbeln.

Re: Loop-EndLoop

Rodrigo-Giner — Mon, 23 Mar 2009 14:18:24 GMT

Maybe because the select return sy-subrc = 4 ?

So the internal table lt_vbap doesnt contains any value to loop. Remember that in a INNER JOIN union if the a value exits in A table but not in B table the statment doesnt return anything.

BTW, I recommend you to make the select outside the LOOPS

Re: Loop-EndLoop

former_member376453 — Mon, 23 Mar 2009 15:13:59 GMT

Try with removing those "(" and ")" . Why u are using this, though you have used this for the same condition field.

Kuntal

Re: Loop-EndLoop

jcutinho — Mon, 23 Mar 2009 15:27:36 GMT

I have proposed a code that might solve your problem, please declare an additional field VBELN in LT_VBAP structure. The code is also performance tuned.

if c_vkdikk is not initial.

SELECT a~vbeln

a~netwr

b~lfimg

a~kwmeng

INTO CORRESPONDING FIELDS OF TABLE lt_vbap

FROM lips AS b

INNER JOIN vbap AS a

ON b_{vgbel = a}vbeln

AND b_{vgpos = a}posnr

FOR ALL ENTRIES IN c_vkdfif

WHERE b~vbeln = c_vkdfif-vbeln.

SORT c_vkdfif BY vbeln.

SORT lt_vbap BY vbeln.

LOOP AT c_vkdfif.

IF c_vkdfif-vbtyp = 'J' OR

c_vkdfif-vbtyp = 'T' OR

c_vkdfif-vbtyp = 'K'.

CLEAR lt_vbap.

READ TABLE lt_vbap WITH KEY vbeln = c_vkdfif-vbeln

BINARY SEARCH.

IF sy-subrc = 0.

LOOP AT lt_vbap FROM sy-tabix.

IF lt_vbap-vbeln = c_vkdfif-vbeln.

lvx_netwr = ( lt_vbap-netwr / lt_vbap-kwmeng ) * lt_vbap-lfimg.

lv_netwr = lv_netwr + lvx_netwr.

IF c_vkdfif-vbtyp = 'T'.

IF lv_netwr > 0 OR lv_netwr = 0.

lv_netwr = -1 * lv_netwr.

ELSE.

lv_netwr = lv_netwr - lvx_netwr.

ENDIF.

ELSEIF c_vkdfif-vbtyp = 'K'.

IF lv_netwr > 0 OR lv_netwr = 0.

lv_netwr = -1 * ( lv_netwr + lvx_netwr ).

ELSE.

lv_netwr = lv_netwr - lvx_netwr.

ENDIF.

ELSE.

EXIT.

ENDIF.

ENDLOOP.

c_vkdfif-netwr = lv_netwr.

MODIFY c_vkdfif.

CLEAR lv_netwr.

ENDIF.

endif.

Re: Loop-EndLoop

Former Member — Wed, 25 Mar 2009 13:32:06 GMT

Thanks I solved my problem with your tip.