topic Re: Please, pretty please, correct this code in Application Development and Automation Discussions

Please, pretty please, correct this code

Former Member — Wed, 03 Dec 2008 13:16:00 GMT

LOOP AT FINAL.
    IF FINAL-PSTYV EQ 'ZTAO'.
      DATA : MPSPHI LIKE PRPS-PSPHI.
      DATA : MPRPS LIKE PRPS OCCURS 0 WITH HEADER LINE.
      DATA : MOBJRN LIKE RPSCO-OBJNR.
            
      SELECT SINGLE * FROM PRPS WHERE PSPNR = FINAL-PS_PSP_PNR.

      MPSPHI = PRPS-PSPHI.

      SELECT * FROM PRPS INTO TABLE MPRPS WHERE PSPHI = MPSPHI.

      SORT MPRPS BY OBJNR.

      LOOP AT MPRPS.

        MOBJNR = PRPS-OBJNR.

      ENDLOOP.

endloop.

when I debug the code MOBJNR is not changing it is taking from row value even it is running in the loop.

kindly correct this code

regards,

Edited by: Matt on Dec 3, 2008 3:53 PM - Subject made less demanding

Re: Please, pretty please, correct this code

Former Member — Wed, 03 Dec 2008 13:23:42 GMT

Hi Raj,


DATA : MPSPHI LIKE PRPS-PSPHI.
DATA : MPRPS LIKE PRPS OCCURS 0 WITH HEADER LINE.
DATA : MOBJRN LIKE RPSCO-OBJNR.

LOOP AT FINAL.
IF FINAL-PSTYV EQ 'ZTAO'.
SELECT SINGLE * FROM PRPS WHERE PSPNR = FINAL-PS_PSP_PNR.
MPSPHI = PRPS-PSPHI.

SELECT * FROM PRPS INTO TABLE MPRPS WHERE PSPHI = MPSPHI.
SORT MPRPS BY OBJNR.

LOOP AT MPRPS.
MOBJNR = PRPS-OBJNR.
ENDLOOP. 

ENDLOOP.

In the loop for MPRPS, the object number wil be overwritten and everytime only the last record from the table MPRPS will be available.

Change that part. It should work. If you want to store the object number in another table, you need to declare a table of type MOBJNR and you need to append records to that table.

Note: Please avoid selects inside loop as it would affect the performance.

Best Regards,

Ram.

Re: Please, pretty please, correct this code

Former Member — Wed, 03 Dec 2008 13:24:36 GMT

u have looped MPRPS but moving PRPS.

move MPRPS then it will work

Regards,

Ajay

Re: Please, pretty please, correct this code

paolo_romano2 — Wed, 03 Dec 2008 13:29:02 GMT

hi raj,

LOOP AT FINAL.

IF FINAL-PSTYV EQ 'ZTAO'.

DATA : MPSPHI LIKE PRPS-PSPHI.

DATA : MPRPS LIKE PRPS OCCURS 0 WITH HEADER LINE.

DATA : MOBJRN LIKE RPSCO-OBJNR.

SELECT SINGLE * FROM PRPS WHERE PSPNR = FINAL-PS_PSP_PNR.

MPSPHI = PRPS-PSPHI.

SELECT * FROM PRPS INTO TABLE MPRPS WHERE PSPHI = MPSPHI.

SORT MPRPS BY OBJNR.

LOOP AT MPRPS.

MOBJNR = MPRPS-OBJNR.

ENDLOOP.

endloop.

cheers,

Re: Please, pretty please, correct this code

Former Member — Wed, 03 Dec 2008 13:37:22 GMT

Hi Paolo,

thanks I got it. Some times it happens...

regards,

Re: Please, pretty please, correct this code

paolo_romano2 — Wed, 03 Dec 2008 13:38:36 GMT

hi raj,

you're right...I make such an error thousands of times...and every time I go crazy to recognize it...

cheers,

Paolo