topic Re: performance problem in code for MARD data in SAP Retail in Application Development and Automation Discussions

performance problem in code for MARD data in SAP Retail

Former Member — Wed, 22 Oct 2008 22:26:02 GMT

Dear all,

I am getting performance problem in following code.

Can any one guide how to improve the performance problem?

SELECT werks matnr lgort labst FROM mard INTO TABLE gt_mardstk

WHERE labst GT u20190u2019.

LOOP AT gt_mardstk .

gt_transfer-matnr = gt_mardstk-matnr .

gt_transfer-werks = gt_mardstk-werks .

gt_transfer-labst = gt_mardstk-labst .

SHIFT gt_transfer-labst RIGHT UP TO '.'.

SHIFT gt_transfer-labst RIGHT.

SHIFT gt_transfer-labst LEFT DELETING LEADING space.

APPEND gt_transfer .

DELETE gt_mardstk WHERE matnr = gt_transfer-matnr

AND werks = gt_transfer-werks

AND labst = gt_transfer-labst.

CLEAR gt_transfer .

ENDLOOP .

DESCRIBE TABLE gt_transfer LINES lv_cnt .

IF lv_cnt > 0 .

PERFORM open_file USING p_file.

LOOP AT gt_transfer .

CONDENSE gt_transfer-labst.

MOVE-CORRESPONDING gt_transfer TO ls_transfer .

MOVE ls_transfer TO lv_string.

TRANSFER lv_string TO p_file .

ENDLOOP .

CLOSE DATASET p_file

Thanks

Re: performance problem in code for MARD data in SAP Retail

Former Member — Wed, 22 Oct 2008 22:27:36 GMT

Did you check Code Inspector and SE30 yourself to figure out potential issues yourself?

Re: performance problem in code for MARD data in SAP Retail

Former Member — Wed, 22 Oct 2008 22:46:07 GMT

In SE30

Evaluate option saying:

ABAP 55.1%

Database 10%

System 34.9%

Do you see any kind of program improvement possibility?

This program is taking more then 10 Hr run and still running,

But total records selected from MARD is 600000.

Thanks

Re: performance problem in code for MARD data in SAP Retail

Former Member — Wed, 22 Oct 2008 23:10:19 GMT

Why are you specifying where condition in trhe Delete command below, it is already in the same loop , so just put delete.


LOOP AT gt_mardstk .
gt_transfer-matnr = gt_mardstk-matnr .
gt_transfer-werks = gt_mardstk-werks .
gt_transfer-labst = gt_mardstk-labst .
SHIFT gt_transfer-labst RIGHT UP TO '.'.
SHIFT gt_transfer-labst RIGHT.
SHIFT gt_transfer-labst LEFT DELETING LEADING space.
APPEND gt_transfer .


DELETE gt_mardstk WHERE matnr = gt_transfer-matnr    <-------------------
AND werks = gt_transfer-werks     <-----------------
AND labst = gt_transfer-labst.       <--------------
CLEAR gt_transfer .
ENDLOOP .

Re: performance problem in code for MARD data in SAP Retail

Former Member — Thu, 23 Oct 2008 17:00:52 GMT

No Solution I think, other then I have to run report for small stores variant, not for bulk run.

I still appreciate if any other solution.

Regards

Re: performance problem in code for MARD data in SAP Retail

Former Member — Thu, 23 Oct 2008 17:28:31 GMT

Did you see the post by MxG? I think that's where your problem lies.

Rob

Re: performance problem in code for MARD data in SAP Retail

Former Member — Fri, 24 Oct 2008 00:49:16 GMT

Thanks for reply, I just combined both loop like follows,

and program takes only 205 sec compared to 44359 with old code.


    SELECT werks matnr lgort labst FROM mard 
                                          INTO TABLE gt_mardstk
                                                WHERE labst GT v_labst.
 

    DESCRIBE TABLE gt_mardstk LINES lv_cnt .
    IF lv_cnt > 0 .
      PERFORM open_file USING p_file.

      LOOP AT gt_mardstk .
        gt_transfer-matnr = gt_mardstk-matnr .
        gt_transfer-werks = gt_mardstk-werks .
        gt_transfer-labst = gt_mardstk-labst .
        SHIFT gt_transfer-labst RIGHT UP TO '.'.
        SHIFT gt_transfer-labst RIGHT.
        SHIFT gt_transfer-labst LEFT DELETING LEADING space.

        IF gt_transfer-labst NE 0.
          CONDENSE gt_transfer-labst.
          MOVE-CORRESPONDING gt_transfer TO ls_transfer .
          MOVE ls_transfer TO lv_string.
          TRANSFER lv_string TO p_file .
        ENDIF.
        CLEAR  gt_transfer .
      ENDLOOP .